From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: isearch highlighting Date: Fri, 10 Dec 2004 07:22:20 +0200 Organization: JURTA Message-ID: <87sm6ezq0j.fsf@jurta.org> References: <87fz2e6h6b.fsf@jurta.org> <87llc6n8wr.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1102656562 13212 80.91.229.6 (10 Dec 2004 05:29:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 10 Dec 2004 05:29:22 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 10 06:29:16 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CcdL9-0007I6-00 for ; Fri, 10 Dec 2004 06:29:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CcdV5-0003LF-Dv for ged-emacs-devel@m.gmane.org; Fri, 10 Dec 2004 00:39:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CcdUz-0003K4-2b for emacs-devel@gnu.org; Fri, 10 Dec 2004 00:39:25 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CcdUy-0003Jm-D2 for emacs-devel@gnu.org; Fri, 10 Dec 2004 00:39:24 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CcdUy-0003Jc-9g for emacs-devel@gnu.org; Fri, 10 Dec 2004 00:39:24 -0500 Original-Received: from [194.126.101.100] (helo=MXR-2.estpak.ee) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CcdKl-00024J-Qb for emacs-devel@gnu.org; Fri, 10 Dec 2004 00:28:52 -0500 Original-Received: from mail.neti.ee (80-235-41-2-dsl.mus.estpak.ee [80.235.41.2]) by MXR-2.estpak.ee (Postfix) with ESMTP id 67D0011BE9A; Fri, 10 Dec 2004 07:28:46 +0200 (EET) Original-To: Stefan Monnier In-Reply-To: <87llc6n8wr.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 09 Dec 2004 22:21:16 -0500") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3.50 (gnu/linux) X-Virus-Scanned: by amavisd-new-20030616-p10 (Debian) at neti.ee X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:30966 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:30966 Stefan Monnier writes: >> I think it is safe to put the body of `isearch-lazy-highlight-update' >> in the `with-local-quit' block, because quit in this function can't >> lead to a corrupted state. > > Agreed. I'd even put it in `while-no-input'. Yes, `while-no-input' would be appropriate here, especially on slow machines. But I see no such thing in Emacs CVS. I only see it in emacs-devel archives where it was heavily discussed two years ago. > You might want to add the patch below, tho, just so the code can't > be interrupted after placing the new overlay but before it's > recorded on the list. OK. >> because most regexps in Emacs packages are well tested and contains no >> nested repetitions. > > Is that an attempt at humor? I looked through rose-colored glasses :-) -- Juri Linkov http://www.jurta.org/emacs/