From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Hourglass only for X-windows? Date: Sat, 12 Mar 2005 08:41:39 -0500 Message-ID: <87sm31f0ld.fsf-monnier+emacs@gnu.org> References: <000701c51cf5$d269ee10$0200a8c0@sedrcw11488> <01c51d0b$Blat.v2.4$215fcf20@zahav.net.il> <003201c51d2b$5c57e2f0$0200a8c0@sedrcw11488> <01c51d4f$Blat.v2.4$8840d7e0@zahav.net.il> <007801c51dae$4674c560$0200a8c0@sedrcw11488> <01c51dea$Blat.v2.4$254bbb00@zahav.net.il> <001901c51df4$1a9400a0$0200a8c0@sedrcw11488> <00b301c525c9$9cf3ba40$0200a8c0@sedrcw11488> <01c5263e$Blat.v2.4$65b1b4e0@zahav.net.il> <4231A0BE.1070704@gnu.org> <00cc01c52653$f3ce6ce0$0200a8c0@sedrcw11488> <01c52655$Blat.v2.4$b47b9200@zahav.net.il> <00ee01c52659$a01c9620$0200a8c0@sedrcw11488> <534dd629871884654f6c43846c34db9a@swipnet.se> <00f501c5266a$1bf72de0$0200a8c0@sedrcw11488> <01c5267c$Blat.v2.4$37bc1380@zahav.net.il> <010601c5269f$660e83d0$0200a8c0@sedrcw11488> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1110636596 6959 80.91.229.2 (12 Mar 2005 14:09:56 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 12 Mar 2005 14:09:56 +0000 (UTC) Cc: hunterd42@comcast.net, Lennart Borgman , Eli Zaretskii , kobayays@otsukakj.co.jp, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 12 15:09:55 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DA7JH-0004Wj-NV for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2005 15:09:44 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DA7YZ-000341-M6 for ged-emacs-devel@m.gmane.org; Sat, 12 Mar 2005 09:25:31 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DA7YJ-00032y-02 for emacs-devel@gnu.org; Sat, 12 Mar 2005 09:25:15 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DA7UX-0002RK-0t for emacs-devel@gnu.org; Sat, 12 Mar 2005 09:21:26 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DA7UU-0002AZ-Rm for emacs-devel@gnu.org; Sat, 12 Mar 2005 09:21:18 -0500 Original-Received: from [209.226.175.54] (helo=tomts10-srv.bellnexxia.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DA6s8-0000m2-AV; Sat, 12 Mar 2005 08:41:40 -0500 Original-Received: from alfajor ([65.92.241.52]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.06.10 201-253-122-130-110-20040306) with ESMTP id <20050312134139.HRXV19622.tomts10-srv.bellnexxia.net@alfajor>; Sat, 12 Mar 2005 08:41:39 -0500 Original-Received: by alfajor (Postfix, from userid 1000) id 8A837D74A3; Sat, 12 Mar 2005 08:41:39 -0500 (EST) Original-To: Jason Rumney In-Reply-To: (Jason Rumney's message of "Sat, 12 Mar 2005 02:11:23 +0000") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34511 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34511 > Conditional compilation constants are not comments. They are not there to > assist your reading of the code, they are there to enable that code > when appropriate. For that purpose, it is actually clearer to have the > constants named so that the conditions under which that code is > enabled is obvious. Having hourglass code surrounded by HAVE_HOURGLASS > is not adding anything, because the actual conditions under which > hourglass cursors are available depend on the platform, not some > configure test. Also someone debugging why hourglass cursors do > not work on a Mac might miss the fact that they are only enabled on X > and W32, that is not likely if we list the real conditions under which > that code is enabled. The other side of the coin is that if you add hourglass support to the Carbon branch, you'll have to check each #ifdef HAVE_X_WINDOWS to see if it relates to hourglass or not. I personally like the HAVE_HOURGLASS style of coding better than the "defined HAVE_X_WINDOWS && defined NT_GUI && ...". But of course, an even better approach might be to remove all those conditionals and simply always provide all the _hourglass functions, even with an empty body if the hourglass functionality is missing for a particular system. It tends to make the code more readable. Stefan