From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lute Kamstra Newsgroups: gmane.emacs.devel Subject: Re: syntax highlight fix for add-log.el Date: Mon, 04 Apr 2005 12:45:42 +0200 Message-ID: <87sm26zup5.fsf@xs4all.nl> References: <87mzsgr4e3.fsf@kali.intranet> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1112637647 24607 80.91.229.2 (4 Apr 2005 18:00:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2005 18:00:47 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 04 20:00:39 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DIVrX-0006L6-Bd for ged-emacs-devel@m.gmane.org; Mon, 04 Apr 2005 19:59:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DIVQG-0002Gg-US for ged-emacs-devel@m.gmane.org; Mon, 04 Apr 2005 13:31:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DIT87-0002KK-Gj for emacs-devel@gnu.org; Mon, 04 Apr 2005 11:04:43 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DISu4-0005iX-JI for emacs-devel@gnu.org; Mon, 04 Apr 2005 10:50:15 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DISp0-0003Xj-1d for emacs-devel@gnu.org; Mon, 04 Apr 2005 10:44:58 -0400 Original-Received: from [194.109.24.21] (helo=smtp-vbr1.xs4all.nl) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DIP71-0002Rk-CI for emacs-devel@gnu.org; Mon, 04 Apr 2005 06:47:19 -0400 Original-Received: from pijl (a80-127-67-124.adsl.xs4all.nl [80.127.67.124]) by smtp-vbr1.xs4all.nl (8.12.11/8.12.11) with ESMTP id j34AjhGH012429; Mon, 4 Apr 2005 12:45:43 +0200 (CEST) (envelope-from Lute.Kamstra@xs4all.nl) Original-Received: from lute by pijl with local (Exim 3.36 #1 (Debian)) id 1DIP5S-0001iB-00; Mon, 04 Apr 2005 12:45:42 +0200 Original-To: Marcelo Toledo In-Reply-To: <87mzsgr4e3.fsf@kali.intranet> (Marcelo Toledo's message of "Sat, 02 Apr 2005 23:16:36 -0300") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) Original-Lines: 52 X-Virus-Scanned: by XS4ALL Virus Scanner X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:35546 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:35546 Marcelo Toledo writes: > The manual describing a Change Log entry, says: (...) "Aside from > these header lines, every line in the change log starts with a space > or a tab.". Your patch goes only half the way in fixing the problem you describe. What about this change to fix the rest? Lute. Index: lisp/add-log.el =================================================================== RCS file: /cvsroot/emacs/emacs/lisp/add-log.el,v retrieving revision 1.158 diff -u -r1.158 add-log.el --- lisp/add-log.el 4 Apr 2005 08:47:07 -0000 1.158 +++ lisp/add-log.el 4 Apr 2005 10:39:11 -0000 @@ -225,8 +225,8 @@ (2 'change-log-email-face))) ;; ;; File names. - ("^\\(?: +\\|\t\\)\\* \\([^ ,:([\n]+\\)" - (1 'change-log-file-face) + ("^\\( +\\|\t\\)\\* \\([^ ,:([\n]+\\)" + (2 'change-log-file-face) ;; Possibly further names in a list: ("\\=, \\([^ ,:([\n]+\\)" nil nil (1 'change-log-file-face)) ;; Possibly a parenthesized list of names: @@ -236,8 +236,8 @@ nil nil (1 'change-log-list-face))) ;; ;; Function or variable names. - ("^\t(\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)" - (1 'change-log-list-face) + ("^\\( +\\|\t\\)(\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)" + (2 'change-log-list-face) ("\\=, *\\([^(),\n]+\\|(\\(setf\\|SETF\\) [^() ,\n]+)\\)" nil nil (1 'change-log-list-face))) ;; @@ -250,8 +250,8 @@ ;; Acknowledgements. ;; Don't include plain "From" because that is vague; ;; we want to encourage people to say something more specific. - ("\\(^\t\\| \\)\\(Patch\\(es\\)? by\\|Report\\(ed by\\| from\\)\\|Suggest\\(ed by\\|ion from\\)\\)" - 2 'change-log-acknowledgement-face)) + ("\\(^\\( +\\|\t\\)\\| \\)\\(Patch\\(es\\)? by\\|Report\\(ed by\\| from\\)\\|Suggest\\(ed by\\|ion from\\)\\)" + 3 'change-log-acknowledgement-face)) "Additional expressions to highlight in Change Log mode.") (defvar change-log-mode-map