unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Size of *Calc-kpd* window too small after M-# b M-# k
@ 2005-10-07  1:48 Luc Teirlinck
  2005-10-07 12:17 ` Luc Teirlinck
  0 siblings, 1 reply; 3+ messages in thread
From: Luc Teirlinck @ 2005-10-07  1:48 UTC (permalink / raw)
  Cc: emacs-devel

Do `emacs -nbc -Q&', `M-# b M-# k'.  Part of the keypad is hidden:
`calc-do-keypad' apparently does not take the size of the fringes into
account.  The trivial patch below fixes this for the default fringe
width.  It would probably be better to use the actual size of the
fringes, but the same applies to other window width computations of
calc, which seem to simply use the default fringe width (or ignore
fringe width altogether).  I know of no other window widths that calc
uses that give trouble with the default fringe width, although line
309 of calc-keypad.el also seems dubious:

	    (setq old-win (split-window old-win (+ width 2) t)))

The patch below does not change that line, only line 299.

===File ~/calc-keypd.el-diff================================
*** calc-keypd.el	14 Jul 2005 15:03:58 -0500	1.11
--- calc-keypd.el	06 Oct 2005 19:48:36 -0500	
***************
*** 296,302 ****
  	      (set-window-buffer old-win (calc-trail-buffer))
  	      (set-window-buffer win calc-keypad-buffer)
  	      (set-window-start win 1)
! 	      (setq win (split-window win (+ width 3) t))
  	      (set-window-buffer win calcbuf))
  	  (if (or t  ; left-side keypad not yet fully implemented
  		  (< (save-excursion
--- 296,302 ----
  	      (set-window-buffer old-win (calc-trail-buffer))
  	      (set-window-buffer win calc-keypad-buffer)
  	      (set-window-start win 1)
! 	      (setq win (split-window win (+ width 6) t))
  	      (set-window-buffer win calcbuf))
  	  (if (or t  ; left-side keypad not yet fully implemented
  		  (< (save-excursion
============================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Size of *Calc-kpd* window too small after M-# b M-# k
  2005-10-07  1:48 Size of *Calc-kpd* window too small after M-# b M-# k Luc Teirlinck
@ 2005-10-07 12:17 ` Luc Teirlinck
  2005-10-07 21:19   ` Jay Belanger
  0 siblings, 1 reply; 3+ messages in thread
From: Luc Teirlinck @ 2005-10-07 12:17 UTC (permalink / raw)
  Cc: emacs-devel

>From my earlier message:

   The trivial patch below fixes this for the default fringe width.

Actually, the `6' needs to be a `7'.  Otherwise, one gets confusing
continuation arrows if overflow-newline-into-fringe is nil.

===File ~/calc-keypd.el-diff================================
*** calc-keypd.el	14 Jul 2005 15:03:58 -0500	1.11
--- calc-keypd.el	06 Oct 2005 19:48:36 -0500	
***************
*** 296,302 ****
  	      (set-window-buffer old-win (calc-trail-buffer))
  	      (set-window-buffer win calc-keypad-buffer)
  	      (set-window-start win 1)
! 	      (setq win (split-window win (+ width 3) t))
  	      (set-window-buffer win calcbuf))
  	  (if (or t  ; left-side keypad not yet fully implemented
  		  (< (save-excursion
--- 296,302 ----
  	      (set-window-buffer old-win (calc-trail-buffer))
  	      (set-window-buffer win calc-keypad-buffer)
  	      (set-window-start win 1)
! 	      (setq win (split-window win (+ width 7) t))
  	      (set-window-buffer win calcbuf))
  	  (if (or t  ; left-side keypad not yet fully implemented
  		  (< (save-excursion
============================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Size of *Calc-kpd* window too small after M-# b M-# k
  2005-10-07 12:17 ` Luc Teirlinck
@ 2005-10-07 21:19   ` Jay Belanger
  0 siblings, 0 replies; 3+ messages in thread
From: Jay Belanger @ 2005-10-07 21:19 UTC (permalink / raw)
  Cc: belanger


Luc Teirlinck <teirllm@dms.auburn.edu> writes:

>>From my earlier message:
>
>    The trivial patch below fixes this for the default fringe width.
>
> Actually, the `6' needs to be a `7'.  Otherwise, one gets confusing
> continuation arrows if overflow-newline-into-fringe is nil.

Thanks; the change has been made.

Jay

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-10-07 21:19 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-07  1:48 Size of *Calc-kpd* window too small after M-# b M-# k Luc Teirlinck
2005-10-07 12:17 ` Luc Teirlinck
2005-10-07 21:19   ` Jay Belanger

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).