Info `i' bug with partial-completion-mode.

Info `i' bug with partial-completion-mode.

[Michaël Cadilhac]

[-- Attachment #1.1.1: Type: text/plain, Size: 340 bytes --]


A small bug. Recipe:

emacs -Q
M-x info RET
m elisp RET
i emacs TAB

Now, the point  will go back to the beginning of  the line, instead of
staying at the end, proposing L, ' ', - to distinguish the input.

It's just due to the fact that the completion mechanism doesn't know
that the search is case insensitive.

Patch proposal follows.


[-- Attachment #1.1.2: info.patch --]
[-- Type: text/x-patch, Size: 1484 bytes --]

Index: ChangeLog
===================================================================
RCS file: /sources/emacs/emacs/lisp/ChangeLog,v
retrieving revision 1.9820
diff -c -r1.9820 ChangeLog
*** ChangeLog	17 Jul 2006 04:07:48 -0000	1.9820
--- ChangeLog	17 Jul 2006 11:36:57 -0000
***************
*** 1,3 ****
--- 1,7 ----
+ 2006-07-17  Michaël Cadilhac  <michael.cadilhac@lrde.org>
+ 
+ 	* info.el (Info-index): Bind `completion-ignore-case' to t.
+ 
  2006-07-17  Chong Yidong  <cyd@stupidchicken.com>
  
  	* progmodes/compile.el (compilation-mode-font-lock-keywords):
Index: info.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/info.el,v
retrieving revision 1.488
diff -c -r1.488 info.el
*** info.el	12 Jul 2006 16:04:46 -0000	1.488
--- info.el	17 Jul 2006 11:36:57 -0000
***************
*** 2792,2798 ****
  Give an empty topic name to go to the Index node itself."
    (interactive
     (list
!     (let ((Info-complete-menu-buffer (clone-buffer))
  	  (Info-complete-nodes (Info-index-nodes))
  	  (Info-history-list nil))
        (if (equal Info-current-file "dir")
--- 2792,2799 ----
  Give an empty topic name to go to the Index node itself."
    (interactive
     (list
!     (let ((completion-ignore-case t)
! 	  (Info-complete-menu-buffer (clone-buffer))
  	  (Info-complete-nodes (Info-index-nodes))
  	  (Info-history-list nil))
        (if (equal Info-current-file "dir")

[-- Attachment #1.1.3: Type: text/plain, Size: 323 bytes --]


-- 
 |      Michaël `Micha' Cadilhac   |  Un certain Blaise Pascal              |
 |         Epita/LRDE Promo 2007   |    etc... etc...                       |
 | http://www.lrde.org/~cadilh_m   |  -- Prévert (Les paris stupides)       |
 `--  -   JID: micha@amessage.be --'                                   -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Info `i' bug with partial-completion-mode.

[Mathias Dahl]

> A small bug. Recipe:
>
> emacs -Q
> M-x info RET
> m elisp RET
> i emacs TAB
>
> Now, the point  will go back to the beginning of  the line, instead of
> staying at the end, proposing L, ' ', - to distinguish the input.

I tried this both on a very recent (some days ago) CVS Emacs on
GNU/Linux and on an older CVS Emacs on Windows, and in both places,
point (in the minibuffer) stays at the end of the string. I can see,
in the completion buffer, a highligted `L' in the "EMACSLOADPATH
environment variable", for example.

In short: I could not recreate this.

Re: Info `i' bug with partial-completion-mode.

[Michaël Cadilhac]

[-- Attachment #1.1: Type: text/plain, Size: 1048 bytes --]

"Mathias Dahl" <mathias.dahl@gmail.com> writes:

>> A small bug. Recipe:
>>
>> emacs -Q
>> M-x info RET
>> m elisp RET
>> i emacs TAB
>>
>> Now, the point  will go back to the beginning of  the line, instead of
>> staying at the end, proposing L, ' ', - to distinguish the input.
>
> I tried this both on a very recent (some days ago) CVS Emacs on
> GNU/Linux and on an older CVS Emacs on Windows, and in both places,
> point (in the minibuffer) stays at the end of the string. I can see,
> in the completion buffer, a highligted `L' in the "EMACSLOADPATH
> environment variable", for example.
>
> In short: I could not recreate this.

Recipe wasn't good: add a M-x partial-completion-mode somewhere :-)

-- 
 |      Michaël `Micha' Cadilhac   |  Would someone please DTRT with this,  |
 |         Epita/LRDE Promo 2007   |        then ACK?                       |
 | http://www.lrde.org/~cadilh_m   |          -- Richard Stallman           |
 `--  -   JID: micha@amessage.be --'                                   -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Info `i' bug with partial-completion-mode.

[Mathias Dahl]

> > In short: I could not recreate this.
>
> Recipe wasn't good: add a M-x partial-completion-mode somewhere :-)

I did. No difference, sorry :(

Re: Info `i' bug with partial-completion-mode.

[Michaël Cadilhac]

[-- Attachment #1.1: Type: text/plain, Size: 944 bytes --]

"Mathias Dahl" <mathias.dahl@gmail.com> writes:

>> > In short: I could not recreate this.
>>
>> Recipe wasn't good: add a M-x partial-completion-mode somewhere :-)
>
> I did. No difference, sorry :(

Okey, you're right. No bug here after recompile. BUT (haha! There's
more!) I triggered another bug that my patch fixes :-)

Recipe:

emacs -Q
M-x partial-completion-mode RET
M-x info RET
m emacs RET
i emacs <TAB> (Okey, good)
Add a space and then <TAB> again. The expected entries are not
displayed:

EMACS environment variable	   Emacs as a server
Emacs icon, a gnu		   Emacs initialization file

-- 
 |      Michaël `Micha' Cadilhac   |  Would someone please DTRT with this,  |
 |         Epita/LRDE Promo 2007   |        then ACK?                       |
 | http://www.lrde.org/~cadilh_m   |          -- Richard Stallman           |
 `--  -   JID: micha@amessage.be --'                                   -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Info `i' bug with partial-completion-mode.

[Mathias Dahl]

> Recipe:
>
> emacs -Q
> M-x partial-completion-mode RET
> M-x info RET
> m emacs RET
> i emacs <TAB> (Okey, good)
> Add a space and then <TAB> again. The expected entries are not
> displayed:

Yes, strange things happen after I add a space and then TAB. And I
cannot even bet the original completions back when I remove the
spaces. Strange. I have not tested your fix and probably won't.

Re: Info `i' bug with partial-completion-mode.

[Michaël Cadilhac]

[-- Attachment #1.1: Type: text/plain, Size: 922 bytes --]

"Mathias Dahl" <mathias.dahl@gmail.com> writes:

>> Recipe:
>>
>> emacs -Q
>> M-x partial-completion-mode RET
>> M-x info RET
>> m emacs RET
>> i emacs <TAB> (Okey, good)
>> Add a space and then <TAB> again. The expected entries are not
>> displayed:
>
> Yes, strange things happen after I add a space and then TAB. And I
> cannot even bet the original completions back when I remove the
> spaces. Strange. I have not tested your fix and probably won't.

I don't think the patch I proposed has been reviewed, has it?

(See http://thread.gmane.org/gmane.emacs.devel/57171)

TIA!

-- 
 |      Michaël `Micha' Cadilhac   |  Un certain Blaise Pascal              |
 |         Epita/LRDE Promo 2007   |    etc... etc...                       |
 | http://www.lrde.org/~cadilh_m   |  -- Prévert (Les paris stupides)       |
 `--  -   JID: micha@amessage.be --'                                   -  --'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel