From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: hexl-mode's offer to "Convert contents back to binary format?" doesn't Date: Wed, 17 Jan 2007 22:22:01 -0500 Message-ID: <87sle9589y.fsf@furball.mit.edu> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1169090549 28484 80.91.229.12 (18 Jan 2007 03:22:29 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 18 Jan 2007 03:22:29 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 18 04:22:24 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1H7Nr6-0006sR-7d for ged-emacs-devel@m.gmane.org; Thu, 18 Jan 2007 04:22:24 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H7Nr6-0005FV-N1 for ged-emacs-devel@m.gmane.org; Wed, 17 Jan 2007 22:22:24 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1H7Nqv-0005F6-LU for emacs-devel@gnu.org; Wed, 17 Jan 2007 22:22:13 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1H7Nqv-0005Eg-3K for emacs-devel@gnu.org; Wed, 17 Jan 2007 22:22:13 -0500 Original-Received: from [18.72.1.2] (helo=south-station-annex.mit.edu) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1H7Nqu-0003YE-Ry; Wed, 17 Jan 2007 22:22:12 -0500 Original-Received: from grand-central-station.mit.edu (GRAND-CENTRAL-STATION.MIT.EDU [18.7.21.82]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l0I3MAlC016407; Wed, 17 Jan 2007 22:22:10 -0500 (EST) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by grand-central-station.mit.edu (8.13.6/8.9.2) with ESMTP id l0I3M2aZ016394; Wed, 17 Jan 2007 22:22:03 -0500 (EST) Original-Received: from furball.mit.edu (SYDNEYPACIFIC-SIX-FORTY-EIGHT.MIT.EDU [18.95.7.137]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l0I3M1Qn001708; Wed, 17 Jan 2007 22:22:02 -0500 (EST) Original-Received: from cyd by furball.mit.edu with local (Exim 3.36 #1 (Debian)) id 1H7Nqj-0003Pl-00; Wed, 17 Jan 2007 22:22:01 -0500 Original-To: "Chris Moore" In-Reply-To: (Chris Moore's message of "Tue\, 16 Jan 2007 18\:02\:26 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.91 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:65264 Archived-At: "Chris Moore" writes: > On 1/14/07, Richard Stallman wrote: >> It seems that hexl-mode needs to set up >> revert-buffer-insert-file-contents-function >> so that it will hexlify the new contents. >> >> Would someone please do that and ack? > > There's a lot of code in revert-buffer which doesn't get used if you > set up revert-buffer-insert-file-contents-function. Code which checks > for conditions like "File %s no longer exists!" and "File %s no longer > readable!" > > The following patch fixes the problem: Thanks. Your patch is indeed the correct solution, and I've checked it in.