From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: transpose-regions Date: Fri, 23 Mar 2007 11:39:40 -0400 Message-ID: <87slbwx937.fsf@stupidchicken.com> References: <46026277.7060305@gmx.at> <87zm64kau0.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1174664943 29301 80.91.229.12 (23 Mar 2007 15:49:03 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2007 15:49:03 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 23 16:48:57 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HUm0d-0001Ys-1t for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 16:48:55 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUm2X-0005aY-5s for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2007 10:50:53 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HUm1F-0003KT-7l for emacs-devel@gnu.org; Fri, 23 Mar 2007 11:49:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HUm1E-0003JI-OY for emacs-devel@gnu.org; Fri, 23 Mar 2007 10:49:32 -0500 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1HUlzJ-0003gn-EY for emacs-devel@gnu.org; Fri, 23 Mar 2007 11:47:33 -0400 Original-Received: from central-city-carrier-station.mit.edu (CENTRAL-CITY-CARRIER-STATION.MIT.EDU [18.7.7.72]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l2NFlUw1012114 for ; Fri, 23 Mar 2007 10:47:32 -0500 (EST) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by central-city-carrier-station.mit.edu (8.13.6/8.9.2) with ESMTP id l2NFdhZv008993 for ; Fri, 23 Mar 2007 11:39:43 -0400 (EDT) Original-Received: from localhost ([18.19.7.211]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l2NFdeoU021617 for ; Fri, 23 Mar 2007 11:39:43 -0400 (EDT) Original-Received: from cyd by localhost with local (Exim 3.36 #1 (Debian)) id 1HUlrg-0005RR-00 for ; Fri, 23 Mar 2007 11:39:40 -0400 In-Reply-To: <87zm64kau0.fsf@stupidchicken.com> (Chong Yidong's message of "Thu\, 22 Mar 2007 21\:28\:07 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.96 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-detected-kernel: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:68405 Archived-At: I've narrowed down the location where the interval plist becomes invalid. I patched Ftranspose_regions in editfns.c as follows: *** emacs/src/editfns.c.~1.436.~ 2007-03-17 15:00:52.000000000 -0400 --- emacs/src/editfns.c 2007-03-23 11:31:06.000000000 -0400 *************** *** 4031,4036 **** --- 4031,4038 ---- It's the caller's job to ensure that START1 <= END1 <= START2 <= END2. */ + extern Lisp_Object Vdead; + static void transpose_markers (start1, end1, start2, end2, start1_byte, end1_byte, start2_byte, end2_byte) *************** *** 4224,4232 **** --- 4226,4245 ---- tmp_interval1 = copy_intervals (cur_intv, start1, len1); tmp_interval2 = copy_intervals (cur_intv, start2, len2); + + if (! NULL_INTERVAL_P (tmp_interval1) + && CONSP (tmp_interval1->plist) + && EQ (XCAR (tmp_interval1->plist), Vdead)) + abort(); + Fset_text_properties (make_number (start1), make_number (end2), Qnil, Qnil); + if (! NULL_INTERVAL_P (tmp_interval1) + && CONSP (tmp_interval1->plist) + && EQ (XCAR (tmp_interval1->plist), Vdead)) + abort(); + /* First region smaller than second. */ if (len1_byte < len2_byte) { Using Martin's recipe, I obtained the following backtrace: #0 abort () at emacs.c:431 #1 0x081af617 in Ftranspose_regions (startr1=104688, endr1=105304, startr2=105304, endr2=105648, leave_markers=137955529) at editfns.c:4241 ... Line 4241 corresponds to the second abort() statement, which means the plist in tmp_interval1 got garbage collected during the call to Fset_text_properties. It looks like Fset_text_properties makes changes to intervals in the buffer; probably this invalidates the plist in tmp_interval1 in some way.