From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: We can use python.el Date: Mon, 14 May 2007 10:55:40 -0400 Message-ID: <87sl9zo3o3.fsf@stupidchicken.com> References: <873b22nd3f.fsf@stupidchicken.com> <87iraxtzkm.fsf@stupidchicken.com> <87abw961jm.fsf@stupidchicken.com> <5kfy61cxjl.fsf@fencepost.gnu.org> <4648211C.7080107@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1179154558 21100 80.91.229.12 (14 May 2007 14:55:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 14 May 2007 14:55:58 +0000 (UTC) Cc: Glenn Morris , emacs-devel@gnu.org, rms@gnu.org, lekktu@gmail.com To: Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon May 14 16:55:56 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hnbxs-0008Rn-GW for ged-emacs-devel@m.gmane.org; Mon, 14 May 2007 16:55:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hnc5d-0004uA-To for ged-emacs-devel@m.gmane.org; Mon, 14 May 2007 11:03:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hnc5a-0004u4-Ho for emacs-devel@gnu.org; Mon, 14 May 2007 11:03:54 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hnc5Z-0004ts-8S for emacs-devel@gnu.org; Mon, 14 May 2007 11:03:53 -0400 Original-Received: from south-station-annex.mit.edu ([18.72.1.2]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Hnbxn-0004pU-42; Mon, 14 May 2007 10:55:51 -0400 Original-Received: from central-city-carrier-station.mit.edu (CENTRAL-CITY-CARRIER-STATION.MIT.EDU [18.7.7.72]) by south-station-annex.mit.edu (8.13.6/8.9.2) with ESMTP id l4EEtlYH011786; Mon, 14 May 2007 10:55:47 -0400 (EDT) Original-Received: from outgoing-legacy.mit.edu (OUTGOING-LEGACY.MIT.EDU [18.7.22.104]) by central-city-carrier-station.mit.edu (8.13.6/8.9.2) with ESMTP id l4EEtfLm010304; Mon, 14 May 2007 10:55:42 -0400 (EDT) Original-Received: from localhost (SYDNEYPACIFIC-SIX-NINETEEN.MIT.EDU [18.95.7.108]) ) by outgoing-legacy.mit.edu (8.13.6/8.12.4) with ESMTP id l4EEteRX005034; Mon, 14 May 2007 10:55:41 -0400 (EDT) Original-Received: from cyd by localhost with local (Exim 3.36 #1 (Debian)) id 1Hnbxc-0002VK-00; Mon, 14 May 2007 10:55:40 -0400 In-Reply-To: <4648211C.7080107@gnu.org> (Jason Rumney's message of "Mon\, 14 May 2007 09\:43\:08 +0100") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.42 X-Spam-Score: -2.599 X-detected-kernel: Solaris 9.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71035 Archived-At: Jason Rumney writes: > Richard Stallman wrote: >> Shouldn't PBM_MONO benefit from the same kind of check? >> Ie, move the check to just after init_color_table, before the if >> block. >> >> Is there a bug in the case of PBM_MONO? If so, I guess we should >> fix it too. But we could also leave it alone, to be conservative. >> > > I think the same bug (a malformed pbm file causing Emacs to crash) > that led to the original change could also affect monochrome images. > Depending on the parsing code, it could also affect ASCII formatted > pnm files, but the fix for that is not as obvious as checking the > length before parsing. I checked in a fix into the trunk (I haven't been able to test this, because I don't know how to create a malformed pbm, but redisplay of valid pbms seems to work.)