From: Chong Yidong <cyd@stupidchicken.com>
To: Jason Rumney <jasonr@gnu.org>
Cc: Glenn Morris <rgm@gnu.org>,
emacs-devel@gnu.org, rms@gnu.org, lekktu@gmail.com
Subject: Re: We can use python.el
Date: Mon, 14 May 2007 10:55:40 -0400 [thread overview]
Message-ID: <87sl9zo3o3.fsf@stupidchicken.com> (raw)
In-Reply-To: <4648211C.7080107@gnu.org> (Jason Rumney's message of "Mon\, 14 May 2007 09\:43\:08 +0100")
Jason Rumney <jasonr@gnu.org> writes:
> Richard Stallman wrote:
>> Shouldn't PBM_MONO benefit from the same kind of check?
>> Ie, move the check to just after init_color_table, before the if
>> block.
>>
>> Is there a bug in the case of PBM_MONO? If so, I guess we should
>> fix it too. But we could also leave it alone, to be conservative.
>>
>
> I think the same bug (a malformed pbm file causing Emacs to crash)
> that led to the original change could also affect monochrome images.
> Depending on the parsing code, it could also affect ASCII formatted
> pnm files, but the fix for that is not as obvious as checking the
> length before parsing.
I checked in a fix into the trunk (I haven't been able to test this,
because I don't know how to create a malformed pbm, but redisplay of
valid pbms seems to work.)
next prev parent reply other threads:[~2007-05-14 14:55 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-12 16:47 We can use python.el Richard Stallman
2007-05-12 17:52 ` Chong Yidong
2007-05-12 18:17 ` Juanma Barranquero
2007-05-12 23:03 ` Chong Yidong
2007-05-12 23:36 ` Juanma Barranquero
2007-05-12 23:54 ` Chong Yidong
2007-05-13 1:38 ` Glenn Morris
2007-05-14 8:08 ` Richard Stallman
2007-05-14 8:43 ` Jason Rumney
2007-05-14 14:55 ` Chong Yidong [this message]
2007-05-14 17:45 ` Glenn Morris
2007-05-14 18:05 ` Henrik Enberg
2007-05-15 9:47 ` Richard Stallman
2007-05-15 14:11 ` Chong Yidong
2007-05-16 1:39 ` Richard Stallman
2007-05-16 2:51 ` Chong Yidong
2007-05-16 6:02 ` Jan Djärv
2007-05-13 10:33 ` Jason Rumney
2007-05-14 8:09 ` Richard Stallman
2007-05-12 19:02 ` pretest 22.0.100 (was: We can use python.el) Reiner Steib
2007-05-12 22:51 ` pretest 22.0.100 Chong Yidong
2007-05-14 17:01 ` Stefan Monnier
2007-05-14 19:11 ` Juanma Barranquero
2007-05-14 21:26 ` Nick Roberts
2007-05-16 15:48 ` Stefan Monnier
2007-05-17 12:42 ` Andreas Schwab
2007-05-17 12:49 ` Jason Rumney
2007-05-17 13:15 ` David Kastrup
2007-05-17 13:25 ` Jason Rumney
2007-05-17 13:34 ` David Kastrup
2007-05-17 13:45 ` Ralf Angeli
2007-05-17 13:57 ` Ulrich Mueller
2007-05-17 14:02 ` Alfred M. Szmidt
2007-05-17 13:39 ` Jay Belanger
2007-05-17 14:20 ` Stefan Monnier
2007-05-17 14:32 ` Juanma Barranquero
2007-05-17 16:43 ` Another pretest after 22.0.99 (was: pretest 22.0.100) Reiner Steib
2007-05-13 1:27 ` We can use python.el Michaël Cadilhac
2007-05-14 8:08 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sl9zo3o3.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=jasonr@gnu.org \
--cc=lekktu@gmail.com \
--cc=rgm@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).