From: Chong Yidong <cyd@stupidchicken.com>
To: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [jbw@macs.hw.ac.uk: part of display property on before-string property is not displayed]
Date: Fri, 12 Oct 2007 15:59:57 -0400 [thread overview]
Message-ID: <87sl4gm7cy.fsf@stupidchicken.com> (raw)
In-Reply-To: <wllkaakt22.wl%mituharu@math.s.chiba-u.ac.jp> (YAMAMOTO Mitsuharu's message of "Thu\, 11 Oct 2007 16\:29\:41 +0900")
YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
> `position' points to it->current.string_pos when
> handle_single_display_spec above is called while processing a
> `display' property in a overlay string, and thus line 4240 overrides
> the effect of line 4232.
>
> I guess the reason to pretend as if the `display' property were not
> processed yet at line 4240 is to process overlay strings at the
> start position of the `display' property later. If this guess is
> correct, then this adjustment would be necessary only when
> processing a `display' property within a buffer text.
>
> Could someone more familiar with redisplay check if the following
> patch DTRT?
I think your reasoning is correct, but instead of
if (!STRINGP (it->stack[it->sp - 1].string))
could you do
if (BUFFERP (object))
instead?
next prev parent reply other threads:[~2007-10-12 19:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-04 2:02 [jbw@macs.hw.ac.uk: part of display property on before-string property is not displayed] Richard Stallman
2007-10-11 7:29 ` YAMAMOTO Mitsuharu
2007-10-12 19:59 ` Chong Yidong [this message]
2007-10-15 8:32 ` YAMAMOTO Mitsuharu
2007-10-15 12:50 ` Chong Yidong
2007-10-16 4:11 ` Richard Stallman
2007-10-16 9:09 ` YAMAMOTO Mitsuharu
2007-10-17 5:03 ` Richard Stallman
-- strict thread matches above, loose matches on Subject: below --
2007-09-26 21:57 Richard Stallman
2007-09-19 15:48 Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sl4gm7cy.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=mituharu@math.s.chiba-u.ac.jp \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).