From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: Tool-bar changes Date: Tue, 13 May 2008 14:07:50 -0400 Message-ID: <87skwmrsax.fsf@stupidchicken.com> References: <18457.37369.262079.668907@kahikatea.snap.net.nz> <200805040056.m440u3eS022727@sallyv1.ics.uci.edu> <874p9dn46h.fsf@stupidchicken.com> <87hcd8i7iq.fsf_-_@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1210702099 10012 80.91.229.12 (13 May 2008 18:08:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 13 May 2008 18:08:19 +0000 (UTC) Cc: Tassilo Horn , Reiner Steib , Juanma Barranquero , emacs-devel@gnu.org, "Sebastian P. Luque" , 225-done@emacsbugs.donarmstrong.com To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 13 20:08:56 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jvyvc-0006L2-7j for ged-emacs-devel@m.gmane.org; Tue, 13 May 2008 20:08:44 +0200 Original-Received: from localhost ([127.0.0.1]:41516 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jvyut-0000wh-70 for ged-emacs-devel@m.gmane.org; Tue, 13 May 2008 14:07:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jvyup-0000wQ-6p for emacs-devel@gnu.org; Tue, 13 May 2008 14:07:55 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jvyun-0000vw-NR for emacs-devel@gnu.org; Tue, 13 May 2008 14:07:54 -0400 Original-Received: from [199.232.76.173] (port=33536 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jvyun-0000vt-JB for emacs-devel@gnu.org; Tue, 13 May 2008 14:07:53 -0400 Original-Received: from cyd.mit.edu ([18.115.2.24]:58022) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jvyun-0004ag-Ly for emacs-devel@gnu.org; Tue, 13 May 2008 14:07:53 -0400 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id 9D5424E392; Tue, 13 May 2008 14:07:50 -0400 (EDT) In-Reply-To: <87hcd8i7iq.fsf_-_@stupidchicken.com> (Chong Yidong's message of "Thu, 08 May 2008 21:35:41 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97091 Archived-At: Chong Yidong writes: > Stefan Monnier writes: > >> I've just installed a change in tool-bar.el which delays the call to >> find-image. Instead of being called in tool-bar-setup, it's now called >> when looking up the tool-bar keymap. This may also allow the toolbar >> to use different icons on different displays (e.g. some color, some b&w) >> in the same Emacs instance. > > This change did Something Bad to the tool-bar on i686-pc-linux-gnu, GTK+ > Version 2.12.9. Only the Cut, Paste, Customize, and Help icons are now > displayed on the tool-bar; the other images are missing. The problem was the the use of plist-get and plist-put in tool-bar-make-keymap failed to account for the format of menu-item lists, which can contain an optional KEY-BINDING-DATA entry that screws up the property list ordering. I just checked in a fix.