Re: save-frame-excursion?

[Bastien <bastienguerry@googlemail.com>]

[-- Attachment #1: Type: text/plain, Size: 447 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> So the really better fix would be to make sure make-frame doesn't change
> the focus (especially since the above note is not quite correct: even
> for click-to-focus WMs, the new frames may get selected just by virtue
> of being new, which is most likely what you're seeing).

This patch makes sure that `make-frame' gives the focus back to the
previously selected frame.

Shall I apply this?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: frame.el.patch --]
[-- Type: text/x-diff, Size: 709 bytes --]

--- frame.el.~1.300.~	2009-07-27 03:20:02.000000000 +0800
+++ frame.el	2009-07-27 11:40:23.000000000 +0800
@@ -749,7 +749,8 @@
 instance if the frame appears under the mouse pointer and your
 setup is for focus to follow the pointer."
   (interactive)
-  (let* ((w (cond
+  (let* ((f (selected-frame))
+	 (w (cond
 	     ((assq 'terminal parameters)
 	      (let ((type (terminal-live-p (cdr (assq 'terminal parameters)))))
 		(cond
@@ -777,6 +778,7 @@
         (let ((val (frame-parameter oldframe param)))
           (when val (set-frame-parameter frame param val)))))
     (run-hook-with-args 'after-make-frame-functions frame)
+    (x-focus-frame f)
     frame))
 
 (defun filtered-frame-list (predicate)

[-- Attachment #3: Type: text/plain, Size: 14 bytes --]


-- 
 Bastien