unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tassilo@member.fsf.org>
To: emacs-devel@gnu.org
Subject: Re: Need help with search based font-locking
Date: Mon, 28 Dec 2009 19:18:01 +0100	[thread overview]
Message-ID: <87skavrmhy.fsf@thinkpad.tsdh.de> (raw)
In-Reply-To: <e01d8a50912280554k7a52a34fm2ebaa84c17d07209@mail.gmail.com> (Lennart Borgman's message of "Mon, 28 Dec 2009 14:54:51 +0100")

Lennart Borgman <lennart.borgman@gmail.com> writes:

Hi Lennart,

>> What's the reason for disabling `font-lock-mode-hook' while
>> deactivating `font-lock-mode', but not while enabling it again?
>
> Oh, thanks. I should have commented on that in the code.
>
> It is just because hi-lock is turned off otherwise. But there is a
> variable
>
>   hi-lock--inhibit-font-lock-hook
>
> I could have used too. However I thought there might be other things
> behaving similar to hi-lock in this respect.

Hm, I think, in that case let-binding `hi-lock--inhibit-font-lock-hook'
would be more appropriate, because it's a special case to circumvent the
asymmetry of the function `hi-lock-font-lock-hook', which switches off
`hi-lock-mode' when `font-lock-mode' is disabled, but doesn't switch it
on in the other case.

If nobody objects, I'll commit version modified this way.

Bye,
Tassilo




  reply	other threads:[~2009-12-28 18:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22 21:45 Need help with search based font-locking Tassilo Horn
2009-12-22 22:43 ` Lennart Borgman
2009-12-23 11:13   ` Tassilo Horn
2009-12-23 11:38     ` Tassilo Horn
2009-12-24  3:07     ` Stefan Monnier
2009-12-24  3:45       ` Lennart Borgman
2009-12-24  4:46         ` Stefan Monnier
2009-12-24 13:48           ` Lennart Borgman
2009-12-28 13:20             ` Tassilo Horn
2009-12-28 13:54               ` Lennart Borgman
2009-12-28 18:18                 ` Tassilo Horn [this message]
2009-12-30 13:56       ` Tassilo Horn
2009-12-30 15:29         ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87skavrmhy.fsf@thinkpad.tsdh.de \
    --to=tassilo@member.fsf.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).