From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: Patch to change just-one-space Date: Tue, 07 Dec 2010 20:45:58 +0100 Message-ID: <87sjy9s6x5.fsf@member.fsf.org> References: <7b501d5c0908131337g300e8895i465719007e29074c@mail.gmail.com> <87fwusjvcy.fsf@member.fsf.org> <201012071043.12395.tassilo@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1291751176 16740 80.91.229.12 (7 Dec 2010 19:46:16 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Dec 2010 19:46:16 +0000 (UTC) Cc: xahlee@gmail.com, Stefan Monnier , Deniz Dogan To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 07 20:46:12 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PQ3UJ-0007Lr-9z for ged-emacs-devel@m.gmane.org; Tue, 07 Dec 2010 20:46:11 +0100 Original-Received: from localhost ([127.0.0.1]:51014 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQ3UI-0005Zi-PO for ged-emacs-devel@m.gmane.org; Tue, 07 Dec 2010 14:46:10 -0500 Original-Received: from [140.186.70.92] (port=43804 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PQ3UB-0005Yc-G0 for emacs-devel@gnu.org; Tue, 07 Dec 2010 14:46:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PQ3UA-0008Fb-HM for emacs-devel@gnu.org; Tue, 07 Dec 2010 14:46:03 -0500 Original-Received: from out3.smtp.messagingengine.com ([66.111.4.27]:34239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PQ3UA-0008FR-Dl for emacs-devel@gnu.org; Tue, 07 Dec 2010 14:46:02 -0500 Original-Received: from compute3.internal (compute3.nyi.mail.srv.osa [10.202.2.43]) by gateway1.messagingengine.com (Postfix) with ESMTP id BE1F23BE; Tue, 7 Dec 2010 14:46:01 -0500 (EST) Original-Received: from frontend2.messagingengine.com ([10.202.2.161]) by compute3.internal (MEProxy); Tue, 07 Dec 2010 14:46:01 -0500 X-Sasl-enc: 7niLlIOZtVY468ixq0H13P/fjCRHSQwmsxd2lvJygLXf 1291751161 Original-Received: from thinkpad (95-88-32-105-dynip.superkabel.de [95.88.32.105]) by mail.messagingengine.com (Postfix) with ESMTPA id 839B05E3D4A; Tue, 7 Dec 2010 14:46:00 -0500 (EST) In-Reply-To: <201012071043.12395.tassilo@member.fsf.org> (Tassilo Horn's message of "Tue, 7 Dec 2010 10:43:11 +0100") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:133516 Archived-At: Tassilo Horn writes: >> >> Any objection to such a change? Removing newlines sounds OK to >> >> me, but I don't use just-one-space, so I don't have a good feeling >> >> for what other useful meaning could be used for a negative >> >> argument. >> >> I saw no objections, so I installed it on the trunk. > > There's a problem with your change. When you call `just-one-space' from > lisp without explicit argument and thus n is nil, you get an error, > because the function expects it to be a number. I've fixed it on the trunk. Bye, Tassilo