From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.devel Subject: Re: color.el Date: Sat, 19 Feb 2011 13:33:08 -0500 Message-ID: <87sjvjj2mz.fsf@stupidchicken.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1298140400 24700 80.91.229.12 (19 Feb 2011 18:33:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 19 Feb 2011 18:33:20 +0000 (UTC) Cc: emacs-devel@gnu.org To: "Drew Adams" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Feb 19 19:33:15 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PqrcJ-0007VO-L2 for ged-emacs-devel@m.gmane.org; Sat, 19 Feb 2011 19:33:15 +0100 Original-Received: from localhost ([127.0.0.1]:42068 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PqrcJ-0005z4-1K for ged-emacs-devel@m.gmane.org; Sat, 19 Feb 2011 13:33:15 -0500 Original-Received: from [140.186.70.92] (port=47986 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PqrcE-0005yy-Sz for emacs-devel@gnu.org; Sat, 19 Feb 2011 13:33:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PqrcD-00019S-Ob for emacs-devel@gnu.org; Sat, 19 Feb 2011 13:33:10 -0500 Original-Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]:44977) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PqrcD-00019K-Mq for emacs-devel@gnu.org; Sat, 19 Feb 2011 13:33:09 -0500 Original-Received: from furball ([64.134.67.165]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p1JIX7ZV004789 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 19 Feb 2011 13:33:08 -0500 Original-Received: by furball (Postfix, from userid 1000) id 7588916081E; Sat, 19 Feb 2011 13:33:08 -0500 (EST) In-Reply-To: (Drew Adams's message of "Wed, 16 Feb 2011 16:23:00 -0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 130.132.50.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136232 Archived-At: "Drew Adams" writes: > I thought that `hexrgb.el' and `color-lab.el' were going to be merged. > > I've merged the two libraries now, moved `read-color' to it, and > cleaned things up (e.g. doc). When there was overlap I kept the best > version (e.g. most precise or most general). I did not include > anything from `eyedropper.el' (e.g. for `read-color'). Thanks. I'll start applying some parts of the patch shortly, but here are a few points worth discussing: 1. Renaming color-rgb->hsv to color-rgb-to-hsv, etc. The latter is a bit more in line with other Emacs Lisp function names, though we do have a few named "X->Y". Any thoughts from Emacs developers? I am not sure myself. 2. Returning HUE in [0,1], rather than radians, by default. If we do this, I'd rather not add a separate *-radians function; we should just decide on whether Emacs should represent hue as [0,1], as radians, or as [0,360], and use that everywhere. For what it's worth, the Gimp, the Java color library, and the Eclipse API all use [0,360]. Maybe we should do follow suit. Any objections? 3. The functions for incrementing color components don't look very useful to me. Surely it's simple enough for a Lisp program to increment a member of a list. Is there any real world example of a program using this part of hexrgb?