From: Chong Yidong <cyd@stupidchicken.com>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: emacs-devel@gnu.org
Subject: Re: color.el
Date: Sat, 19 Feb 2011 13:33:08 -0500 [thread overview]
Message-ID: <87sjvjj2mz.fsf@stupidchicken.com> (raw)
In-Reply-To: <A8AB8E71037349B8AD9F75566706FE4F@us.oracle.com> (Drew Adams's message of "Wed, 16 Feb 2011 16:23:00 -0800")
"Drew Adams" <drew.adams@oracle.com> writes:
> I thought that `hexrgb.el' and `color-lab.el' were going to be merged.
>
> I've merged the two libraries now, moved `read-color' to it, and
> cleaned things up (e.g. doc). When there was overlap I kept the best
> version (e.g. most precise or most general). I did not include
> anything from `eyedropper.el' (e.g. for `read-color').
Thanks. I'll start applying some parts of the patch shortly, but here
are a few points worth discussing:
1. Renaming color-rgb->hsv to color-rgb-to-hsv, etc.
The latter is a bit more in line with other Emacs Lisp function
names, though we do have a few named "X->Y".
Any thoughts from Emacs developers? I am not sure myself.
2. Returning HUE in [0,1], rather than radians, by default.
If we do this, I'd rather not add a separate *-radians function; we
should just decide on whether Emacs should represent hue as [0,1], as
radians, or as [0,360], and use that everywhere.
For what it's worth, the Gimp, the Java color library, and the
Eclipse API all use [0,360]. Maybe we should do follow suit. Any
objections?
3. The functions for incrementing color components don't look very
useful to me. Surely it's simple enough for a Lisp program to
increment a member of a list. Is there any real world example of a
program using this part of hexrgb?
next prev parent reply other threads:[~2011-02-19 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-17 0:23 color.el Drew Adams
2011-02-19 18:33 ` Chong Yidong [this message]
2011-02-20 0:17 ` color.el Drew Adams
2011-02-20 1:10 ` color.el Miles Bader
2011-02-20 3:19 ` color.el Drew Adams
2011-02-20 4:07 ` color.el Miles Bader
2011-02-20 15:44 ` color.el Drew Adams
2011-02-21 17:30 ` color.el Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjvjj2mz.fsf@stupidchicken.com \
--to=cyd@stupidchicken.com \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).