From: Chong Yidong <cyd@gnu.org>
To: emacs-devel@gnu.org
Subject: Re: Inclusion of naquadah-theme
Date: Thu, 28 Jun 2012 15:36:03 +0800 [thread overview]
Message-ID: <87sjdf28ik.fsf@gnu.org> (raw)
In-Reply-To: <87k3yujqmn.fsf@zelenka.enovance.com> (Julien Danjou's message of "Tue, 26 Jun 2012 12:48:16 +0200")
Julien Danjou <julien@danjou.info> writes:
> What do you think of the following patch?
> + * term.el (term-handle-colors-array): Use a set of new faces to
> + color the terminal. Also uses :inverse-video property.
For consistency with the rest of Emacs, please use two spaces after each
sentence.
Please mark term-default-fg-color and term-default-bg-color as
deprecated, instead of deleting them outright. Something like this:
(defcustom term-default-fg-color
(face-foreground term-current-face)
"If non-nil, default color for foreground in Term mode."
:group 'term
:type 'string)
(defface term-face
(if term-default-fg-color
`((t :foreground ,term-default-fg-color :inherit default))
'((t :inherit default)))
"Default face to use in Term mode."
:group 'term)
and similarly for term-default-bg-color. It is not necessary to handle
term-bold-attribute this way since it is just a defvar.
Please add a ChangeLog entry for each changed variable,
e.g. term-bold-attribute should say "Variable deleted". Also, write a
NEWS item noting the deprecation of term-default-*-color and the
introduction of the new faces.
The rest of the patch looks fine. Go ahead and commit once you have
made the above changes, and thanks.
>> Having defuns in a theme file is obnoxious. Could you explain what
>> these functions are needed for? If there is missing functionality, we
>> should incorporate that directly into Emacs; they should not be
>> naquadah-specific.
>
> It's a system we built to define faces with symbols and then expand
> into a real color value, depending on the terminal capability. This
> allows to define a face once with generic color and expand it:
I'm not sure I understand. If you specify a face with a color like
"#252A2B", doesn't Emacs display the closest matching color on terminals
with limited colors?
next prev parent reply other threads:[~2012-06-28 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 10:13 Inclusion of naquadah-theme Julien Danjou
2012-06-25 13:49 ` Chong Yidong
2012-06-26 10:48 ` Julien Danjou
2012-06-28 7:36 ` Chong Yidong [this message]
2012-06-28 10:42 ` Julien Danjou
2012-06-30 2:15 ` Chong Yidong
2012-07-02 21:02 ` Julien Danjou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjdf28ik.fsf@gnu.org \
--to=cyd@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).