From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 51e7e46: Font-lock elisp macros/special forms dynamically Date: Wed, 18 Mar 2015 17:12:32 +0100 Message-ID: <87sid2nv2n.fsf@gnu.org> References: <20150315082509.21193.18465@vcs.savannah.gnu.org> <55054CE9.6010702@dancol.org> <87bnjt4e00.fsf@gnu.org> <550681E3.7080407@dancol.org> <871tkpov7p.fsf@gnu.org> <877fug8z8u.fsf@gnu.org> <55073F67.20809@dancol.org> <87k2yg55jl.fsf@gnu.org> <87sid2epuu.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1426695173 32350 80.91.229.3 (18 Mar 2015 16:12:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Mar 2015 16:12:53 +0000 (UTC) Cc: Daniel Colascione , Artur Malabarba , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 18 17:12:44 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YYGaJ-0008Kj-OQ for ged-emacs-devel@m.gmane.org; Wed, 18 Mar 2015 17:12:43 +0100 Original-Received: from localhost ([::1]:34659 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYGaI-0008KJ-U3 for ged-emacs-devel@m.gmane.org; Wed, 18 Mar 2015 12:12:42 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYGaF-0008Il-43 for emacs-devel@gnu.org; Wed, 18 Mar 2015 12:12:40 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YYGaB-0004Zj-3G for emacs-devel@gnu.org; Wed, 18 Mar 2015 12:12:39 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:54999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YYGaA-0004ZY-TT for emacs-devel@gnu.org; Wed, 18 Mar 2015 12:12:35 -0400 Original-Received: from thinkpad-t440p (dhcp132.uni-koblenz.de [141.26.71.132]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id F2E1A1A8456; Wed, 18 Mar 2015 17:12:32 +0100 (CET) Mail-Followup-To: Stefan Monnier , Daniel Colascione , Artur Malabarba , emacs-devel In-Reply-To: (Stefan Monnier's message of "Wed, 18 Mar 2015 09:13:20 -0400") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 141.26.64.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183995 Archived-At: Stefan Monnier writes: >> Ok. I just tried it anyway, and with jit-lock disabled, >> `font-lock-flush' does nothing, e.g., the buffer portion you have > > I think you've just found a bug. How did you disable jit-lock? Finding vhdl-mode.el (because that's large) and then doing M-: (jit-lock-mode nil). > Can you try "emacs -Q --eval '(setq font-lock-support-mode nil)'" and > retry your test. Yes. So I did that and found vhdl-mode.el again. Nothing is fontified. (font-lock-flush) doesn't change that, but (font-lock-ensure) fontifies the complete buffer. >> If no one comes up with a (semi-)automated way of identifying >> function-like macros, I'll go check the ~1300 macros in emacs >> manually. > > We could also do it lazily: wait for people to complain and fix those > that come up. That's a good plan. :-) So Daniel and Drew, feel free to complain about concrete macros. Or just add a (declare (no-font-lock-keyword t)) to them yourself. >> + just there to save a funcall (ad-get-advice-info-macro, >> shadow-cluster-name) >> Shouldn't those be defsubsts instead of macros? > > Yes, but sometimes having them as macros is better (e.g., the code > should be a bit faster than with a defsubst; also macros are expanded > by gv.el so defining them as macros lets you use them as places in > `setf' and `push' as well. The new `define-inline' does address both > of those problems, OTOH). Oh, cool. Is that going to be an alternative to `defsubst' or is the plan to make it `defsubst' at some point in time? (At least from a very brief look, it seems to provide the same interface for the same use-case.) Bye, Tassilo