From: Tassilo Horn <tsdh@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Daniel Colascione <dancol@dancol.org>,
Artur Malabarba <bruce.connor.am@gmail.com>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] master 51e7e46: Font-lock elisp macros/special forms dynamically
Date: Wed, 18 Mar 2015 17:12:32 +0100 [thread overview]
Message-ID: <87sid2nv2n.fsf@gnu.org> (raw)
In-Reply-To: <jwvtwxia1y8.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 18 Mar 2015 09:13:20 -0400")
Stefan Monnier <monnier@IRO.UMontreal.CA> writes:
>> Ok. I just tried it anyway, and with jit-lock disabled,
>> `font-lock-flush' does nothing, e.g., the buffer portion you have
>
> I think you've just found a bug. How did you disable jit-lock?
Finding vhdl-mode.el (because that's large) and then doing M-:
(jit-lock-mode nil).
> Can you try "emacs -Q --eval '(setq font-lock-support-mode nil)'" and
> retry your test.
Yes. So I did that and found vhdl-mode.el again. Nothing is fontified.
(font-lock-flush) doesn't change that, but (font-lock-ensure) fontifies
the complete buffer.
>> If no one comes up with a (semi-)automated way of identifying
>> function-like macros, I'll go check the ~1300 macros in emacs
>> manually.
>
> We could also do it lazily: wait for people to complain and fix those
> that come up.
That's a good plan. :-)
So Daniel and Drew, feel free to complain about concrete macros. Or
just add a (declare (no-font-lock-keyword t)) to them yourself.
>> + just there to save a funcall (ad-get-advice-info-macro,
>> shadow-cluster-name)
>> Shouldn't those be defsubsts instead of macros?
>
> Yes, but sometimes having them as macros is better (e.g., the code
> should be a bit faster than with a defsubst; also macros are expanded
> by gv.el so defining them as macros lets you use them as places in
> `setf' and `push' as well. The new `define-inline' does address both
> of those problems, OTOH).
Oh, cool. Is that going to be an alternative to `defsubst' or is the
plan to make it `defsubst' at some point in time? (At least from a very
brief look, it seems to provide the same interface for the same
use-case.)
Bye,
Tassilo
next prev parent reply other threads:[~2015-03-18 16:12 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150315082509.21193.18465@vcs.savannah.gnu.org>
[not found] ` <E1YX3rB-0005WV-PA@vcs.savannah.gnu.org>
2015-03-15 9:12 ` [Emacs-diffs] master 51e7e46: Font-lock elisp macros/special forms dynamically Daniel Colascione
2015-03-15 15:11 ` Artur Malabarba
2015-03-15 17:20 ` Drew Adams
2015-03-15 19:15 ` Stefan Monnier
2015-03-16 1:35 ` Artur Malabarba
2015-03-16 3:07 ` Stefan Monnier
2015-03-16 7:07 ` Tassilo Horn
2015-03-16 7:10 ` Daniel Colascione
2015-03-16 7:54 ` Tassilo Horn
2015-03-16 9:36 ` Tassilo Horn
2015-03-16 12:58 ` Stefan Monnier
2015-03-16 14:47 ` Tassilo Horn
2015-03-16 17:31 ` Stefan Monnier
2015-03-16 20:26 ` Tassilo Horn
2015-03-16 20:39 ` Daniel Colascione
2015-03-16 20:56 ` Stefan Monnier
2015-03-17 9:36 ` Tassilo Horn
2015-03-17 10:17 ` Artur Malabarba
2015-03-17 16:34 ` Stefan Monnier
2015-03-17 16:47 ` Nicolas Richard
2015-03-18 7:17 ` Tassilo Horn
2015-03-18 9:10 ` Artur Malabarba
2015-03-18 9:20 ` Dmitry Gutov
2015-03-18 13:13 ` Stefan Monnier
2015-03-18 16:12 ` Tassilo Horn [this message]
2015-03-18 16:44 ` Stefan Monnier
2015-03-16 12:56 ` Stefan Monnier
2015-03-16 7:41 ` Tassilo Horn
2015-03-16 12:59 ` Stefan Monnier
2015-03-16 14:23 ` Artur Malabarba
2015-03-15 15:09 ` Artur Malabarba
2015-03-16 6:40 ` [Emacs-diffs] " Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sid2nv2n.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=bruce.connor.am@gmail.com \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).