From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ingo Lohmar Newsgroups: gmane.emacs.devel Subject: Re: master 397e316: Add option `calendar-weekend-days' Date: Tue, 04 Aug 2015 18:01:19 +0200 Message-ID: <87si7zvy9c.fsf@acer.localhost.com> References: <20150802153051.8158.16904@vcs.savannah.gnu.org> <87mvy88ikq.fsf@acer.localhost.com> <0qr3njdpox.fsf@fencepost.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1438704781 29228 80.91.229.3 (4 Aug 2015 16:13:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Aug 2015 16:13:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 04 18:12:57 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZMepk-00056t-Eu for ged-emacs-devel@m.gmane.org; Tue, 04 Aug 2015 18:12:56 +0200 Original-Received: from localhost ([::1]:36175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMepj-0005Dg-N8 for ged-emacs-devel@m.gmane.org; Tue, 04 Aug 2015 12:12:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34747) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMeeh-0001eh-Hb for emacs-devel@gnu.org; Tue, 04 Aug 2015 12:01:35 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMeed-0007q7-HC for emacs-devel@gnu.org; Tue, 04 Aug 2015 12:01:31 -0400 Original-Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:36128) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMeeX-0007ku-NL; Tue, 04 Aug 2015 12:01:21 -0400 Original-Received: by wicgj17 with SMTP id gj17so156956773wic.1; Tue, 04 Aug 2015 09:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=urBJh/XjYnj6TlxzC347HGowXFS7E4niElMJDVL6P9Y=; b=UjYAw5aobrQ4gNpZJycKsuOlzcY9KwDZwoNcFVDKQEstPq3BOGfCAASv2BcSr3ug9a 51kFu3xCNFtDq6Ulo8AlUXyBwoRdRrT3QgV8AiS6G6lQO3vZibA4jIB1NMEgEO66+UFs RM49d0U1puntCiexZcd4LBcJl0VCK7PCPkq1ytRjXfQAFJZMdL5fhg7tndOWFuuJTLqc WGvtuHQ7hFBYLm8spbcC30U6Jd8hoxVl20i8KJUiAYZkoNBkirO3QYQxoo2NMZ9m+0e0 +GC8psLWw+Vkdzm9eygjUuOEWoAHqdFpgWMf/a8fKY5K9+tmbl8dKOpCpEqQemwzLoRq m1/A== X-Received: by 10.194.92.236 with SMTP id cp12mr9272705wjb.139.1438704080702; Tue, 04 Aug 2015 09:01:20 -0700 (PDT) Original-Received: from localhost (xdsl-213-168-109-215.netcologne.de. [213.168.109.215]) by smtp.gmail.com with ESMTPSA id cw8sm2493729wjb.49.2015.08.04.09.01.19 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2015 09:01:19 -0700 (PDT) In-Reply-To: <0qr3njdpox.fsf@fencepost.gnu.org> User-Agent: Notmuch/0.19+110~gb2cc2a6 (http://notmuchmail.org) Emacs/25.0.50.3 (x86_64-unknown-linux-gnu) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c05::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:188397 Archived-At: On Tue, Aug 04 2015 11:43 (-0400), Glenn Morris wrote: > It's no problem, don't worry about it. > > Adding a missing commit message to a later commit, like in 4e1bdd44, > where you added a commit log for lisp/calendar/calendar.el, which wasn't > changed at all in that change, isn't the right way to correct things > though. It just causes confusion when reading the git log, and now there > will be three entries for this change in the generated ChangeLog. What > you are supposed to do is (from admin/notes/repo) run 'make > change-history' (or wait till Sunday when that happens automatically), > then edit ChangeLog.2 to correct it and commit it. Feel free to correct > any of the docs if there was something that would have made this stuff > clearer to you. (You're not the first person to edit ChangeLog.2 by hand.) > > Wrt doc/emacs/calendar.texi, you're missing a final ".". at the end of > the sentence you added. (I'm not sure this was worth adding, since the > header faces aren't even mentioned in the manual. Not everything needs > to be. Which calendar systems even have something other than two > consecutive weekend days?) Alright, thanks again. I have read up on this and will try to fix the changelog now. But first, I am first going to fix the doc (I also was hesitant to mention it at all, but figured that a single sentence at precisely that place could be helpful). As for the rationale: It's not about anything other than two consecutive days, actually. But, eg, in Israel, Friday(!) and Saturday are weekend days. And in general, weekend days cannot be deduced from the start of the week: Both the US and Europe have Sat/Sun weekends, but in the US, the week AFAIK conventionally starts on Sun, while in Europe, it starts on Mon.