* e73b0d6: Implement unprettification of symbol at point
@ 2015-09-30 15:54 Mark Oteiza
2015-10-01 8:07 ` Tassilo Horn
2015-10-01 13:57 ` Artur Malabarba
0 siblings, 2 replies; 6+ messages in thread
From: Mark Oteiza @ 2015-09-30 15:54 UTC (permalink / raw)
To: emacs-devel; +Cc: Tassilo Horn
> * lisp/progmodes/prog-mode.el: Implement feature for unprettifying the
> symbol at point.
> (prettify-symbols--current-symbol-bounds): New variable.
> (prettify-symbols--post-command-hook): New function.
> (prettify-symbols-unprettify-at-point): New defcustom.
> (prettify-symbols-mode): Use it.
> (prettify-symbols--compose-symbol): Use them.
All the new changing of text properties is modifying the buffer.
Also, why is this defaulting to on?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: e73b0d6: Implement unprettification of symbol at point
2015-09-30 15:54 e73b0d6: Implement unprettification of symbol at point Mark Oteiza
@ 2015-10-01 8:07 ` Tassilo Horn
2015-10-01 13:57 ` Artur Malabarba
1 sibling, 0 replies; 6+ messages in thread
From: Tassilo Horn @ 2015-10-01 8:07 UTC (permalink / raw)
To: Mark Oteiza; +Cc: emacs-devel
Mark Oteiza <mvoteiza@udel.edu> writes:
>> * lisp/progmodes/prog-mode.el: Implement feature for unprettifying the
>> symbol at point.
>> (prettify-symbols--current-symbol-bounds): New variable.
>> (prettify-symbols--post-command-hook): New function.
>> (prettify-symbols-unprettify-at-point): New defcustom.
>> (prettify-symbols-mode): Use it.
>> (prettify-symbols--compose-symbol): Use them.
>
> All the new changing of text properties is modifying the buffer.
>
> Also, why is this defaulting to on?
Just for informing you: a copy of this mail without Cc to emacs-devel
was sent to my email address. I've solved the modification issue, and
the feature is now off by default.
Bye,
Tassilo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: e73b0d6: Implement unprettification of symbol at point
2015-09-30 15:54 e73b0d6: Implement unprettification of symbol at point Mark Oteiza
2015-10-01 8:07 ` Tassilo Horn
@ 2015-10-01 13:57 ` Artur Malabarba
2015-10-03 0:49 ` Xue Fuqiao
1 sibling, 1 reply; 6+ messages in thread
From: Artur Malabarba @ 2015-10-01 13:57 UTC (permalink / raw)
To: Mark Oteiza; +Cc: Tassilo Horn, emacs-devel
[-- Attachment #1: Type: text/plain, Size: 263 bytes --]
> All the new changing of text properties is modifying the buffer.
I think this was addressed in a later commit.
> Also, why is this defaulting to on?
So those who follow the master branch are exposed to it and give feedback.
We can always change the default.
[-- Attachment #2: Type: text/html, Size: 361 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: e73b0d6: Implement unprettification of symbol at point
2015-10-01 13:57 ` Artur Malabarba
@ 2015-10-03 0:49 ` Xue Fuqiao
2015-10-03 5:51 ` Tassilo Horn
0 siblings, 1 reply; 6+ messages in thread
From: Xue Fuqiao @ 2015-10-03 0:49 UTC (permalink / raw)
To: Artur Malabarba; +Cc: Mark Oteiza, emacs-devel, Tassilo Horn
Hi Artur,
Would you please edit the NEWS entry for this feature? It says "symbols
are not prettified while point is inside them", but the default value of
`prettify-symbols-unprettify-at-point' is nil now.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: e73b0d6: Implement unprettification of symbol at point
2015-10-03 0:49 ` Xue Fuqiao
@ 2015-10-03 5:51 ` Tassilo Horn
2015-10-03 7:12 ` Xue Fuqiao
0 siblings, 1 reply; 6+ messages in thread
From: Tassilo Horn @ 2015-10-03 5:51 UTC (permalink / raw)
To: Xue Fuqiao; +Cc: Artur Malabarba, Mark Oteiza, emacs-devel
Xue Fuqiao <xfq.free@gmail.com> writes:
> Would you please edit the NEWS entry for this feature? It says "symbols
> are not prettified while point is inside them", but the default value of
> `prettify-symbols-unprettify-at-point' is nil now.
Done!
Bye,
Tassilo
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: e73b0d6: Implement unprettification of symbol at point
2015-10-03 5:51 ` Tassilo Horn
@ 2015-10-03 7:12 ` Xue Fuqiao
0 siblings, 0 replies; 6+ messages in thread
From: Xue Fuqiao @ 2015-10-03 7:12 UTC (permalink / raw)
To: Xue Fuqiao, Artur Malabarba, Mark Oteiza, emacs-devel
On Sat, Oct 3, 2015 at 1:51 PM, Tassilo Horn <tsdh@gnu.org> wrote:
> Xue Fuqiao <xfq.free@gmail.com> writes:
>
>> Would you please edit the NEWS entry for this feature? It says "symbols
>> are not prettified while point is inside them", but the default value of
>> `prettify-symbols-unprettify-at-point' is nil now.
>
> Done!
Thanks, Tassilo!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-03 7:12 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-30 15:54 e73b0d6: Implement unprettification of symbol at point Mark Oteiza
2015-10-01 8:07 ` Tassilo Horn
2015-10-01 13:57 ` Artur Malabarba
2015-10-03 0:49 ` Xue Fuqiao
2015-10-03 5:51 ` Tassilo Horn
2015-10-03 7:12 ` Xue Fuqiao
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).