From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: Is it time to drop ChangeLogs? Date: Tue, 08 Mar 2016 20:57:59 +0100 Message-ID: <87si0091yw.fsf@wanadoo.es> References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87vb4zb0i4.fsf@gnu.org> <837fheuu6a.fsf@gnu.org> <877fheb1rh.fsf@wanadoo.es> <87ziua9mwq.fsf@wanadoo.es> <83h9git36k.fsf@gnu.org> <87vb4y9ep9.fsf@wanadoo.es> <83a8mat2aa.fsf@gnu.org> <87r3fm9du0.fsf@wanadoo.es> <834mchtz8q.fsf@gnu.org> <878u1ta97x.fsf@wanadoo.es> <83mvq9rmh6.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1457467120 4556 80.91.229.3 (8 Mar 2016 19:58:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 19:58:40 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 08 20:58:32 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1adNm2-0001Jv-DX for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 20:58:30 +0100 Original-Received: from localhost ([::1]:36939 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adNm1-0000BW-QO for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 14:58:29 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49829) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adNln-0000B2-Ff for emacs-devel@gnu.org; Tue, 08 Mar 2016 14:58:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1adNlk-0001ua-AE for emacs-devel@gnu.org; Tue, 08 Mar 2016 14:58:15 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:60950) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1adNlk-0001uT-3q for emacs-devel@gnu.org; Tue, 08 Mar 2016 14:58:12 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1adNlh-00011n-75 for emacs-devel@gnu.org; Tue, 08 Mar 2016 20:58:09 +0100 Original-Received: from 151.red-79-153-146.dynamicip.rima-tde.net ([79.153.146.151]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 08 Mar 2016 20:58:09 +0100 Original-Received: from ofv by 151.red-79-153-146.dynamicip.rima-tde.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 08 Mar 2016 20:58:09 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 46 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 151.red-79-153-146.dynamicip.rima-tde.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) Cancel-Lock: sha1:w4uwTQejBi7csIUxfW9cKns4eH0= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201197 Archived-At: Eli Zaretskii writes: >> From: Óscar Fuentes >> Date: Tue, 08 Mar 2016 05:23:46 +0100 >> >> >> Introduce code reviews. Don't give commit access to the "golden" >> >> branches to everyone, just to a few top contributors and reviewers. >> > >> > We don't have manpower for that. >> >> I find perplexing that we have manpower for reviewing ChangeLogs but not >> for reviewing commit logs *instead*. > > I'm surprised that you find it perplexing. > > Log messages are much shorter than code diffs, It is not necessary to review the diff (except for newcomers, possibly, but that's an added bonus.) [snip] >> And is it so super-important to have typo-free commit logs? > > Typos is the least of our problems. But yes, it's important: if you > start by forgiving typos, you end with unhelpful and uninformative log > messages. Please note that typos are usually corrected by someone else, not by the committer. AFAIR so far nobody received a warning for too much typos, but everybody will see as a reasonable procedure to warn a contributor for poor log messages. Which, as I said elsewhere, Emacs *already* has plenty. I can't imagine what can be worse than what we have now except for leaving a blank commit log or filling it with M-x cookie. I'll reiterate my impression about ChangeLogs being a strong factor on the lack of useful content of Emacs' commit messages. >> We are not even using `git notes'. > > No one came up with a detailed procedure for doing that. If you can > propose something that works, please do. It's simple: put the corrected commit log on a note. When the ChangeLogs are generated, if a commit has a note, use the note instead of the commit log message.