2 release blocking bugs left for 25.1!

2 release blocking bugs left for 25.1!

[John Wiegley]

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

Hello all,

Next week marks the artificial date we'd hoped to have 25.1 ready by -- June
21 -- and it looks like we're very close to being ready for a release
candidate on that date. Debbugs shows me just two blockers left:

  23760 emacs 25.0.95 doesn't build with glibc-2.23.90
  23705 Upper-case abbrev expansion doesn't work with subword-mode enabled

I've also not seen a crash on my system with NS in the past month and a half
(built with -O3 and object checking disabled).

Once we get these remaining bugs closed, and if Eli agrees, I'd like to ask
Nicolas to cut the first release candidate for 25.1. If that candidate can
survive in the wild for a few weeks without generating any new blocking bugs,
I think we may have our release!

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 629 bytes --]

Re: 2 release blocking bugs left for 25.1!

[Eli Zaretskii]

> From: John Wiegley <jwiegley@gmail.com>
> Cc: Nicolas Petton <nicolas@petton.fr>, Eli Zaretskii <eliz@gnu.org>,
> 	Richard Stallman <rms@gnu.org>
> Date: Sat, 18 Jun 2016 09:54:11 -0700
> 
>   23760 emacs 25.0.95 doesn't build with glibc-2.23.90
>   23705 Upper-case abbrev expansion doesn't work with subword-mode enabled

IMO, both should be closed.

Re: 2 release blocking bugs left for 25.1!

[John Wiegley]

[-- Attachment #1: Type: text/plain, Size: 357 bytes --]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

> IMO, both should be closed.

Unless anyone else objects, I would also be fine with that, allowing Nicolas
to cut the first RC as soon as he has time.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 629 bytes --]

Re: 2 release blocking bugs left for 25.1!

[Eli Zaretskii]

> From: John Wiegley <jwiegley@gmail.com>
> Cc: emacs-devel@gnu.org,  nicolas@petton.fr,  rms@gnu.org
> Date: Sat, 18 Jun 2016 10:24:33 -0700
> 
> > IMO, both should be closed.
> 
> Unless anyone else objects, I would also be fine with that, allowing Nicolas
> to cut the first RC as soon as he has time.

Please wait for a few days, I'd like to have 23779 fixed on the
release branch, if no objections are heard.

Re: 2 release blocking bugs left for 25.1!

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

John Wiegley <jwiegley@gmail.com> writes:

> Unless anyone else objects, I would also be fine with that, allowing Nicolas
> to cut the first RC as soon as he has time.

I could cut the first RC Friday if we are ready.

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: 2 release blocking bugs left for 25.1!

[Phillip Lord]

On Sat, June 18, 2016 5:54 pm, John Wiegley wrote:
> Hello all,
>
>
> Next week marks the artificial date we'd hoped to have 25.1 ready by --
> June
> 21 -- and it looks like we're very close to being ready for a release
> candidate on that date. Debbugs shows me just two blockers left:
>
> 23760 emacs 25.0.95 doesn't build with glibc-2.23.90
> 23705 Upper-case abbrev expansion doesn't work with subword-mode enabled
> Once we get these remaining bugs closed, and if Eli agrees, I'd like to
> ask Nicolas to cut the first release candidate for 25.1. If that candidate
> can survive in the wild for a few weeks without generating any new
> blocking bugs, I think we may have our release!


I'd like to suggest 23785 as a blocker also -- the bug (in the report) is
not too serious, but as a fix may involve a change in the command loop,
I'd rather do this before a RC.

We have some fixes, and it should not take too long.

Re: 2 release blocking bugs left for 25.1!

[John Wiegley]

>>>>> Phillip Lord <phillip.lord@russet.org.uk> writes:

> I'd like to suggest 23785 as a blocker also -- the bug (in the report) is
> not too serious, but as a fix may involve a change in the command loop, I'd
> rather do this before a RC.

If the bug is not too serious, can you explain the rationale for making it a
blocker?

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: 2 release blocking bugs left for 25.1!

[Phillip Lord]

John Wiegley <jwiegley@gmail.com> writes:

>>>>>> Phillip Lord <phillip.lord@russet.org.uk> writes:
>
>> I'd like to suggest 23785 as a blocker also -- the bug (in the report) is
>> not too serious, but as a fix may involve a change in the command loop, I'd
>> rather do this before a RC.
>
> If the bug is not too serious, can you explain the rationale for making it a
> blocker?


The symptoms are not too serious, but it's a bug in the undo system, so
may have significant implications elsewhere.

Phil

Re: 2 release blocking bugs left for 25.1!

[Stefan Monnier]

>>> I'd like to suggest 23785 as a blocker also -- the bug (in the report) is
>>> not too serious, but as a fix may involve a change in the command loop, I'd
>>> rather do this before a RC.
>> If the bug is not too serious, can you explain the rationale for making it a
>> blocker?
> The symptoms are not too serious, but it's a bug in the undo system, so
> may have significant implications elsewhere.

And it's a regression in 25.1 due to the new undo code.


        Stefan

Re: 2 release blocking bugs left for 25.1!

[John Wiegley]

>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>>> I'd like to suggest 23785 as a blocker also -- the bug (in the report) is
>>>> not too serious, but as a fix may involve a change in the command loop,
>>>> I'd rather do this before a RC.
>>> If the bug is not too serious, can you explain the rationale for making it
>>> a blocker?
>> The symptoms are not too serious, but it's a bug in the undo system, so may
>> have significant implications elsewhere.

> And it's a regression in 25.1 due to the new undo code.

This does sounds like a blocker, then. What are the repercussions for fixing
the issue? Will it need a full round of pretesting to become ready for the
release candidate?

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: 2 release blocking bugs left for 25.1!

[Eli Zaretskii]

> From: John Wiegley <jwiegley@gmail.com>
> Date: Tue, 21 Jun 2016 11:43:49 -0700
> Cc: emacs-devel@gnu.org
> 
> > And it's a regression in 25.1 due to the new undo code.
> 
> This does sounds like a blocker, then. What are the repercussions for fixing
> the issue? Will it need a full round of pretesting to become ready for the
> release candidate?

No, I don't think so.  It's a localized solution for a localized
problem.

Re: 2 release blocking bugs left for 25.1!

[John Wiegley]

>>>>> Eli Zaretskii <eliz@gnu.org> writes:

>> This does sounds like a blocker, then. What are the repercussions for fixing
>> the issue? Will it need a full round of pretesting to become ready for the
>> release candidate?

> No, I don't think so. It's a localized solution for a localized problem.

Not a blocker then. How is the other blocker you were working on coming along?
Are we ready for an RC on Friday?

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: 2 release blocking bugs left for 25.1!

[Phillip Lord]

John Wiegley <jwiegley@gmail.com> writes:

>>>>>> Eli Zaretskii <eliz@gnu.org> writes:
>
>>> This does sounds like a blocker, then. What are the repercussions for fixing
>>> the issue? Will it need a full round of pretesting to become ready for the
>>> release candidate?
>
>> No, I don't think so. It's a localized solution for a localized problem.
>
> Not a blocker then.

I have applied the patches for these now -- the localized solution has
gone to Emacs-25, and then more general solution to master.

Phil

Re: 2 release blocking bugs left for 25.1!

[Óscar Fuentes]

phillip.lord@russet.org.uk (Phillip Lord) writes:

> I have applied the patches for these now -- the localized solution has
> gone to Emacs-25, and then more general solution to master.

The change in emacs-25 eventually will be merged into master. Is that
your intention?

Re: 2 release blocking bugs left for 25.1!

[Paul Eggert]

I have recently been running into what appears to be a new display bug 
with emacs-25 on an xterm display and just now got around to filing a 
bug report (Bug#23819). Dunno how to fix it offhand, or even to 
reproduce it reliably alas (perhaps someone with tty display expertise 
can look into it?). It'd be nice if Emacs 25 didn't have this 
regression, as it's confusing when the display gets trashed.

Re: 2 release blocking bugs left for 25.1!

[Phillip Lord]

Óscar Fuentes <ofv@wanadoo.es> writes:

> phillip.lord@russet.org.uk (Phillip Lord) writes:
>
>> I have applied the patches for these now -- the localized solution has
>> gone to Emacs-25, and then more general solution to master.
>
> The change in emacs-25 eventually will be merged into master. Is that
> your intention?

That was my original intention, but the change turned out to be daft,
and has been reverted. So, there is still an open issue here that I need
to deal with (and am currently not sure the right way to deal with).

What ever fix I make for emacs-25 should probably go to master anyway.
Having both should cause no harm, besides, the general solution might
not work and get reverted!

Phil

Re: 2 release blocking bugs left for 25.1!

[Mark Oteiza]

Paul Eggert <eggert@cs.ucla.edu> writes:

> I have recently been running into what appears to be a new display bug
> with emacs-25 on an xterm display and just now got around to filing a
> bug report (Bug#23819). Dunno how to fix it offhand, or even to
> reproduce it reliably alas (perhaps someone with tty display expertise
> can look into it?). It'd be nice if Emacs 25 didn't have this
> regression, as it's confusing when the display gets trashed.

Likely not related, but Bug#21177 is a regression I experience that
results in frequent display corruption.

Re: 2 release blocking bugs left for 25.1!

[Eli Zaretskii]

> From: Mark Oteiza <mvoteiza@udel.edu>
> Date: Mon, 27 Jun 2016 22:56:50 -0400
> 
> Paul Eggert <eggert@cs.ucla.edu> writes:
> 
> > I have recently been running into what appears to be a new display bug
> > with emacs-25 on an xterm display and just now got around to filing a
> > bug report (Bug#23819). Dunno how to fix it offhand, or even to
> > reproduce it reliably alas (perhaps someone with tty display expertise
> > can look into it?). It'd be nice if Emacs 25 didn't have this
> > regression, as it's confusing when the display gets trashed.
> 
> Likely not related, but Bug#21177 is a regression I experience that
> results in frequent display corruption.

I proposed some tests for digging into these tricky problems, and I'm
still waiting for someone to pick up the gauntlet.

TIA