* Re: master 39f0543 1/2: vc-git-print-log: pass "--follow" to "log" to handle renamed files
[not found] ` <20161115001349.628D2220171@vcs.savannah.gnu.org>
@ 2016-11-15 0:19 ` Óscar Fuentes
2016-11-15 0:24 ` Sam Steingold
0 siblings, 1 reply; 3+ messages in thread
From: Óscar Fuentes @ 2016-11-15 0:19 UTC (permalink / raw)
To: emacs-devel; +Cc: Sam Steingold
sds@gnu.org (Sam Steingold) writes:
> branch: master
> commit 39f0543ca18142f318a1c90f100632c49a000a1c
> Author: Sam Steingold <sds@gnu.org>
> Commit: Sam Steingold <sds@gnu.org>
>
> vc-git-print-log: pass "--follow" to "log" to handle renamed files
Are you aware of
commit 85a5f61f29516b4e3fa132976e8ea07f76d11cf1
Author: Glenn Morris <rgm@gnu.org>
Date: Tue Jan 21 21:01:40 2014 -0500
* lisp/vc/vc-git.el (vc-git-print-log): Remove --follow;
reverts 2014-01-09 change.
Fixes: debbugs:16422
?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 39f0543 1/2: vc-git-print-log: pass "--follow" to "log" to handle renamed files
2016-11-15 0:19 ` master 39f0543 1/2: vc-git-print-log: pass "--follow" to "log" to handle renamed files Óscar Fuentes
@ 2016-11-15 0:24 ` Sam Steingold
2016-11-15 0:44 ` Óscar Fuentes
0 siblings, 1 reply; 3+ messages in thread
From: Sam Steingold @ 2016-11-15 0:24 UTC (permalink / raw)
To: Óscar Fuentes; +Cc: emacs-devel
No, I was not - until now.
I used the change for a month before committing it and was pretty happy.
I will revert the commit and add a comment.
Sorry.
On Mon, Nov 14, 2016 at 7:19 PM, Óscar Fuentes <ofv@wanadoo.es> wrote:
> sds@gnu.org (Sam Steingold) writes:
>
>> branch: master
>> commit 39f0543ca18142f318a1c90f100632c49a000a1c
>> Author: Sam Steingold <sds@gnu.org>
>> Commit: Sam Steingold <sds@gnu.org>
>>
>> vc-git-print-log: pass "--follow" to "log" to handle renamed files
>
> Are you aware of
>
> commit 85a5f61f29516b4e3fa132976e8ea07f76d11cf1
> Author: Glenn Morris <rgm@gnu.org>
> Date: Tue Jan 21 21:01:40 2014 -0500
>
> * lisp/vc/vc-git.el (vc-git-print-log): Remove --follow;
> reverts 2014-01-09 change.
>
> Fixes: debbugs:16422
>
> ?
--
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: master 39f0543 1/2: vc-git-print-log: pass "--follow" to "log" to handle renamed files
2016-11-15 0:24 ` Sam Steingold
@ 2016-11-15 0:44 ` Óscar Fuentes
0 siblings, 0 replies; 3+ messages in thread
From: Óscar Fuentes @ 2016-11-15 0:44 UTC (permalink / raw)
To: Sam Steingold, emacs-devel
Sam Steingold <sds@gnu.org> writes:
> No, I was not - until now.
> I used the change for a month before committing it and was pretty happy.
> I will revert the commit and add a comment.
> Sorry.
Thanks.
I was aware of the removal of --follow because I wanted it there too :-)
Apart from the problem described on the bug report, IIRC other people
mentioned that it makes the command significantly slower, so it is not a
good candidate as a default.
Maybe we can test for the presence of --follow and remove it from the
git command when the target is a directory?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-15 0:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20161115001349.10574.64519@vcs.savannah.gnu.org>
[not found] ` <20161115001349.628D2220171@vcs.savannah.gnu.org>
2016-11-15 0:19 ` master 39f0543 1/2: vc-git-print-log: pass "--follow" to "log" to handle renamed files Óscar Fuentes
2016-11-15 0:24 ` Sam Steingold
2016-11-15 0:44 ` Óscar Fuentes
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).