From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: phillip.lord@russet.org.uk (Phillip Lord) Newsgroups: gmane.emacs.devel Subject: Re: Merging Org tests Date: Wed, 15 Feb 2017 10:55:46 +0000 Message-ID: <87shnfiuz1.fsf@russet.org.uk> References: <871sv0oljt.fsf@gmx.us> <87lgt8myhm.fsf@russet.org.uk> <871sv01t2m.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1487156588 20757 195.159.176.226 (15 Feb 2017 11:03:08 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 15 Feb 2017 11:03:08 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.91 (gnu/linux) Cc: Rasmus , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 15 12:03:01 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cdxMS-0004jk-4F for ged-emacs-devel@m.gmane.org; Wed, 15 Feb 2017 12:03:00 +0100 Original-Received: from localhost ([::1]:39716 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdxMX-0003Ua-T0 for ged-emacs-devel@m.gmane.org; Wed, 15 Feb 2017 06:03:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36836) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdxFb-0005dy-F4 for emacs-devel@gnu.org; Wed, 15 Feb 2017 05:55:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdxFY-0005HT-Ee for emacs-devel@gnu.org; Wed, 15 Feb 2017 05:55:55 -0500 Original-Received: from mailgw.mycpanelcloud.co.uk ([185.116.214.125]:41228) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cdxFY-0005H6-1Y for emacs-devel@gnu.org; Wed, 15 Feb 2017 05:55:52 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTP id 7B418C628D for ; Wed, 15 Feb 2017 10:55:22 +0000 (GMT) X-Virus-Scanned: by SpamTitan at mycpanelcloud.co.uk Original-Received: from mailgw.mycpanelcloud.co.uk (localhost [127.0.0.1]) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTP id 7A235C6233 for ; Wed, 15 Feb 2017 10:55:21 +0000 (GMT) Original-Received: from cloud103.planethippo.com (cloud103.planethippo.com [31.216.48.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mailgw.mycpanelcloud.co.uk (Postfix) with ESMTPS id 72238C606A for ; Wed, 15 Feb 2017 10:55:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=russet.org.uk; s=default; h=Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=4efc6ps91bVmHKARcJhzZFLFE05S5HJzRycRvbuOtYE=; b=XmyUolfT3RanpqoujasUhnc+E jTe0KPDpJLDYm8hrFdrwhtXzwcJonU1fAHEmOkIlL1FztJqRvpfVuY2VzLXxxv4IYvUJnNE1myWW/ xfrgcEw/gZnbnwiVnF+CEB85Dy2x5llWHGBhuj7t8afJIzOqbUBQRCgjFYlA7NGJyLIms3ZMxJw05 UOZcLy7hGxCRHGpH1lpeRD1A5721C+GVA7IOUiexNeshvz9sgWZ8dE5TEMnQK/dTBat28wcHCmHHV EeobLwVLS191RZmEDKSQqYSyTs06mLxOFwGAbdkj1d2zA/k8UyzC/ataMKVq7AQ0POK9mo/mulO0q D5BlJYnRQ==; Original-Received: from janus-nat-128-240-225-37.ncl.ac.uk ([128.240.225.37]:59270 helo=russet.org.uk) by cloud103.planethippo.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.87) (envelope-from ) id 1cdxFS-002jH3-NX; Wed, 15 Feb 2017 10:55:46 +0000 In-Reply-To: <871sv01t2m.fsf@gmx.de> (Michael Albinus's message of "Tue, 14 Feb 2017 20:16:33 +0100") X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cloud103.planethippo.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - russet.org.uk X-Get-Message-Sender-Via: cloud103.planethippo.com: authenticated_id: phillip.lord@russet.org.uk X-Authenticated-Sender: cloud103.planethippo.com: phillip.lord@russet.org.uk X-detected-operating-system: by eggs.gnu.org: FreeBSD 8.x [fuzzy] X-Received-From: 185.116.214.125 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:212397 Archived-At: Michael Albinus writes: > phillip.lord@russet.org.uk (Phillip Lord) writes: > >>> Also, how strictly must the suggested file organization be followed? >>> Skimming "make-test-deps.emacs-lisp" it seems it might have to be followed >>> rather strictly. >> >> It depends what you want. make-test-deps.emacs-lisp is there so that >> "make check-maybe" can work sanely to run (some approximation of) just >> those tests that need running. I thought this was a good thing to have, >> because "make check" takes too long to run in a commit hook. > > In general it is a good thing (tm). But there shall be > improvements. Currently, if you want to run foo-tests.el, it depends on > foo.el. Often, this is sufficient. But for larger packages, like Org or > Tramp, this is not sufficient. So it might be good to maintain a list of > foo*.el files, a test file foo-tests.el shall depend on. Of course. make-test-deps.emacs-lisp just generates a make file for the cases where I can infer dependencies based on the name. If there are special cases, we could just stick the dependencies in to the main Makefile by hand. Or, alternatively, rewrite make-test-deps.emacs-lisp to be more intelligent and pull out require forms from the test files. Phil