From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Yuri D'Elia Newsgroups: gmane.emacs.devel Subject: Re: HiDPI support for wave style underlines Date: Mon, 21 Aug 2017 14:20:56 +0200 Message-ID: <87shgl5cyf.fsf@wavexx.thregr.org> References: <83wp6r3ed8.fsf@gnu.org> <83shgpe1cp.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1503318118 19292 195.159.176.226 (21 Aug 2017 12:21:58 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 21 Aug 2017 12:21:58 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 21 14:21:53 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djliG-0004WH-Rz for ged-emacs-devel@m.gmane.org; Mon, 21 Aug 2017 14:21:48 +0200 Original-Received: from localhost ([::1]:39942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djliN-0004ue-L3 for ged-emacs-devel@m.gmane.org; Mon, 21 Aug 2017 08:21:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djlhg-0004tn-Tk for emacs-devel@gnu.org; Mon, 21 Aug 2017 08:21:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djlhe-0002FO-7E for emacs-devel@gnu.org; Mon, 21 Aug 2017 08:21:12 -0400 Original-Received: from [195.159.176.226] (port=56797 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djlhe-0002Eg-0S for emacs-devel@gnu.org; Mon, 21 Aug 2017 08:21:10 -0400 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1djlhU-0001un-1H for emacs-devel@gnu.org; Mon, 21 Aug 2017 14:21:00 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 18 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:bXce7adzyEYGzn3bWcmuufZtPd0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217650 Archived-At: On Fri, Aug 18 2017, Eli Zaretskii wrote: >> Good point regarding the emacs_abort(), I honestly didn't think through that. >> I have modified x_get_scale_factor to return a new struct >> x_display_scale with x and y components which are used in the wave >> length and height calculation. >> Indentations and comment grammar have been fixed up as well. > > Sorry for the long delay. > > Thanks, I pushed this with minor changes. Specifically, the function > you added is only used in the same file where it is defined, so it > should be static and its prototype doesn't need to be in xterm.h. > Also, for returning just 2 values, it is better to provide 2 pointer > arguments than to invent a new struct. I actually get a floating point exception with this since I rebuilt emacs on the 19th. I'm rebuilding emacs now with debug to check where it's located, but I pinpointed it to flyspell so...