From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: John Shahid Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 35e0305: Avoid turning on the global-minor-mode recursively Date: Tue, 10 Jul 2018 20:07:40 +0000 Message-ID: <87sh4qvoqb.fsf@gmail.com> References: <20180710121715.23096.25536@vcs0.savannah.gnu.org> <20180710121716.D4670204EE@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1531253150 602 195.159.176.226 (10 Jul 2018 20:05:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 10 Jul 2018 20:05:50 +0000 (UTC) User-Agent: mu4e 1.1.0; emacs 27.0.50 Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 10 22:05:46 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fcytM-0008UR-Sv for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2018 22:05:45 +0200 Original-Received: from localhost ([::1]:49583 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcyvT-0003xX-RN for ged-emacs-devel@m.gmane.org; Tue, 10 Jul 2018 16:07:55 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fcyvM-0003x9-SX for emacs-devel@gnu.org; Tue, 10 Jul 2018 16:07:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fcyvK-0007Tg-7U for emacs-devel@gnu.org; Tue, 10 Jul 2018 16:07:48 -0400 Original-Received: from mail-qk0-x231.google.com ([2607:f8b0:400d:c09::231]:44363) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fcyvK-0007TY-1Y for emacs-devel@gnu.org; Tue, 10 Jul 2018 16:07:46 -0400 Original-Received: by mail-qk0-x231.google.com with SMTP id v17-v6so9811539qkb.11 for ; Tue, 10 Jul 2018 13:07:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=PHD21KdUmO9kl2wqRcDGTb8mBGoyN8bMzeyNb4XRhnI=; b=coYraELEhrqat1a6/QljZWFgmCseXk9PuVpOGeK2mA2NkoQ7lFyY0FnmMgeeg/UFYQ vcs81q50y7CN2hC7f/ZdYQiw8/CikNYZ4CAwxQ3zpQnWSzEFuOI4o5Vqjb/z4+9/FueB vq+bGTQAvIr9d6bjY0OGgQl2nHSBU84R8TVivTiRY9Njv+J3dmfaFZlqxddSL2oE3KwM 3PjM1qz6aSDwtAHtE6CGr002EsqFlqpe7Ij7iUgNk2FSv6nN5XFi+X0zkvDmxZs1LW0g p1QpPmHkq6XugYav8Bnw7LLDz/GbaDkt94PWk6UBMe5tPvZRuFa+Ti+4AELkvncoODzt V5ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=PHD21KdUmO9kl2wqRcDGTb8mBGoyN8bMzeyNb4XRhnI=; b=ohjR8jHmkhu4iRqw7HVg2tVtmF7oQ9UKIKfp6xTMH8AbFiNZAGMAPhoSOsbjwSmAyd hxhdYU0j7+0tiiCEj4dVQQowlb7BF1H0lWiSvmh8QS/zL/0qtN/DZw7XKybGlYWz/U9S poacESjdYonFaJkysMvDqhHfDl2xwqMlObGv/JFMGJExC4B2c+PHEF+WDWiGwPGiFQMz VG1g3aB0WhAsL7RaWYEwDieYDzD//K9GbxJe6rXY/MB9RorsN/nXsQ1Roo6T3ShgmJN7 RVhuoIXZ+pIh2RJQWSw+rnKa6eMrv6otXzppHZjYeBeykV6nZxrkPOwbqPbkd9boNPBz ptdQ== X-Gm-Message-State: APt69E0VOtlfgZRuuWimCP7S+088yn80z3CKplNxfHH1BHo8uY+QsACb WEzKBhSnV8DVz8/cpKjueYEFvUV7 X-Google-Smtp-Source: AAOMgpenPjmYDUzuI2lWG2V5K1A/QT/9tvdu1d4KoW9bVLgxNpgdQDz+ni3FSU++9wyWXz25sR/xkw== X-Received: by 2002:a37:cb86:: with SMTP id u6-v6mr22963277qkl.383.1531253264936; Tue, 10 Jul 2018 13:07:44 -0700 (PDT) Original-Received: from 9c36aecee1b8 (PIVOTAL.ear2.NewYork1.Level3.net. [4.7.3.42]) by smtp.gmail.com with ESMTPSA id m15-v6sm14015014qki.44.2018.07.10.13.07.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Jul 2018 13:07:43 -0700 (PDT) In-reply-to: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:227224 Archived-At: Stefan Monnier writes: >> + (let ((buffers ,MODE-buffers)) >> + ;; Clear MODE-buffers to avoid scanning the same list of >> + ;; buffers in recursive calls to MODE-enable-in-buffers. >> + ;; Otherwise it could lead to infinite recursion. >> + (setq ,MODE-buffers nil) >> + (dolist (buf buffers) > > Thanks. > > BTW, in most other places where we need to "extract the content" of > a worklist like above, we do it with something like: > > (... (prog1 FOO (setq FOO nil)) ...) > > > -- Stefan Should I submit a patch ?