Re: master 6a00f2b: Handle buffer-local 'window-size-change-functions' specially (Bug#32637)

Re: master 6a00f2b: Handle buffer-local 'window-size-change-functions' specially (Bug#32637)

[Michael Albinus]

rudalics@gmx.at (Martin Rudalics) writes:

> branch: master
> commit 6a00f2babf84f309fa00269bff3abef7eb502023
> Author: Martin Rudalics <rudalics@gmx.at>
> Commit: Martin Rudalics <rudalics@gmx.at>
>
>     Handle buffer-local 'window-size-change-functions' specially (Bug#32637)
>     
>     * src/window.c (run_window_size_change_functions): Run a
>     buffer-local value once per each frame and only if at least
>     one window showing the buffer on that frame has changed its
>     size.  (Bug#32637)
>     * doc/lispref/windows.texi (Window Hooks): Describe new
>     behavior of buffer-local 'window-size-change-functions'.

This fails compilation

window.c: In function ‘run_window_size_change_functions’:
window.c:3473:11: error: wrong type argument to unary exclamation mark
        && !Fmemq (buffer, buffers)
           ^
Makefile:385: recipe for target 'window.o' failed
make[1]: *** [window.o] Error 1

Best regards, Michael.

Re: master 6a00f2b: Handle buffer-local 'window-size-change-functions' specially (Bug#32637)

[martin rudalics]

 >>      Handle buffer-local 'window-size-change-functions' specially (Bug#32637)
 >>
 >>      * src/window.c (run_window_size_change_functions): Run a
 >>      buffer-local value once per each frame and only if at least
 >>      one window showing the buffer on that frame has changed its
 >>      size.  (Bug#32637)
 >>      * doc/lispref/windows.texi (Window Hooks): Describe new
 >>      behavior of buffer-local 'window-size-change-functions'.
 >
 > This fails compilation
 >
 > window.c: In function ‘run_window_size_change_functions’:
 > window.c:3473:11: error: wrong type argument to unary exclamation mark
 >          && !Fmemq (buffer, buffers)
 >             ^
 > Makefile:385: recipe for target 'window.o' failed
 > make[1]: *** [window.o] Error 1

Thanks for the heads-up.  Either I got distracted by the
'get_proc_addr' warnings or my compiler is too old.  Should be fixed
now (also with the last two conjuncts reverted, so don't get surprised
when you merge this into tramp-thread-safe).

Thanks again, martin

Re: master 6a00f2b: Handle buffer-local 'window-size-change-functions' specially (Bug#32637)

[Michael Albinus]

martin rudalics <rudalics@gmx.at> writes:

> Thanks for the heads-up.  Either I got distracted by the
> 'get_proc_addr' warnings or my compiler is too old.  Should be fixed
> now (also with the last two conjuncts reverted, so don't get surprised
> when you merge this into tramp-thread-safe).

Thanks!

> Thanks again, martin

Best regards, Michael.