From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail
From: Adam Porter <adam@alphapapa.net>
Newsgroups: gmane.emacs.devel
Subject: Re: [PATCH] pcase.el: Add type pattern
Date: Tue, 10 Mar 2020 10:48:53 -0500
Message-ID: <87sgig8b2y.fsf@alphapapa.net>
References: <874kuxxuez.fsf@alphapapa.net> <875zfd1i5n.fsf@ericabrahamsen.net>
Mime-Version: 1.0
Content-Type: text/plain
Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202";
	logging-data="83648"; mail-complaints-to="usenet@ciao.gmane.io"
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux)
To: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Mar 10 16:51:01 2020
Return-path: <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Envelope-to: ged-emacs-devel@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jBh9p-000LcN-29
	for ged-emacs-devel@m.gmane-mx.org; Tue, 10 Mar 2020 16:51:01 +0100
Original-Received: from localhost ([::1]:36016 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>)
	id 1jBh9o-0001Qw-51
	for ged-emacs-devel@m.gmane-mx.org; Tue, 10 Mar 2020 11:51:00 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53853)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ged-emacs-devel@m.gmane-mx.org>) id 1jBh8v-0000bl-T4
 for emacs-devel@gnu.org; Tue, 10 Mar 2020 11:50:06 -0400
Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <ged-emacs-devel@m.gmane-mx.org>) id 1jBh8v-0002QD-0J
 for emacs-devel@gnu.org; Tue, 10 Mar 2020 11:50:05 -0400
Original-Received: from ciao.gmane.io ([159.69.161.202]:44548)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32)
 (Exim 4.71) (envelope-from <ged-emacs-devel@m.gmane-mx.org>)
 id 1jBh8u-0002O1-QD
 for emacs-devel@gnu.org; Tue, 10 Mar 2020 11:50:04 -0400
Original-Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <ged-emacs-devel@m.gmane-mx.org>) id 1jBh8s-000KaB-91
 for emacs-devel@gnu.org; Tue, 10 Mar 2020 16:50:02 +0100
X-Injected-Via-Gmane: http://gmane.org/
X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]
 [fuzzy]
X-Received-From: 159.69.161.202
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Emacs development discussions." <emacs-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/emacs-devel>
List-Post: <mailto:emacs-devel@gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-devel>,
 <mailto:emacs-devel-request@gnu.org?subject=subscribe>
Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org
Original-Sender: "Emacs-devel"
 <emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org>
Xref: news.gmane.io gmane.emacs.devel:245430
Archived-At: <http://permalink.gmane.org/gmane.emacs.devel/245430>

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

> One thing that's nice about cl-typep is that it will correctly identify
> instances of subclasses, which can be nice. Dunno how difficult it might
> be to work that in there, but it's something to consider. Either way
> this is a nice addition.

Hi Eric,

Please see the latest patch, attached to my reply to Michael.  As
recommended, it uses cl-typep, which allows patterns like:

(type integer)
(type (integer 0 10))

And it should work with subclasses as well.

Thanks.