From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Mingde (Matthew) Zeng" Newsgroups: gmane.emacs.devel Subject: Re: [PATCHv3] erc: fix erc-reuse-buffers behavior Date: Tue, 04 Aug 2020 13:08:33 -0400 Message-ID: <87sgd2e3u6.fsf@gmail.com> References: <871rkr7pme.fsf@gmail.com> <87tuxjvk10.fsf@gnu.org> <87k0yfyv1r.fsf@gmail.com> <87lfiuu836.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33305"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.4.12; emacs 27.0.91 Cc: "Mingde \(Matthew\) Zeng" , Amin Bandali , emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 04 19:13:17 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k30V3-0008Wy-BT for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Aug 2020 19:13:17 +0200 Original-Received: from localhost ([::1]:44178 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k30V2-0006KK-ES for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Aug 2020 13:13:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35640) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k30Qh-0001cN-0Y for emacs-devel@gnu.org; Tue, 04 Aug 2020 13:08:47 -0400 Original-Received: from mail-qt1-x830.google.com ([2607:f8b0:4864:20::830]:42542) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k30Qf-0006WU-5E; Tue, 04 Aug 2020 13:08:46 -0400 Original-Received: by mail-qt1-x830.google.com with SMTP id c12so22465160qtn.9; Tue, 04 Aug 2020 10:08:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=ZgCctXF8QsamCUaqmZPhgB56AMVOBpCk7x5SxTmc5dw=; b=O1ff4ck2gfA0qF/mgvqfSD6c0PT5w8W8jgwrFt5f8Mfw1vmY9J6ubgsj3+a7OGf8vB 8lJTU7dtGZ5UM25l4XwdfGhGPeQQ2HxVl6tEgyAJFP/IcJokIQDW+NTPsRVFPWTkTCZj Tw/QBIVWeEW8feoqYpvFIEHyFFXefq320cQoFJ4jPP0XJ+W3eGvl0hsTbH6kyuq1qusk uC4knLTwvWBH/af4fTj7rP/I9sD49JJrnu8CE3+LTQnnjpf2kAHsSHRKvJYVzKsjGDnL TEvogoTcxNCo83qidmzuq6wN9KLcdJlYeiF2mI1Lf/ssGEIuNYQTvDKCYOrsRM0bNt95 u09w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=ZgCctXF8QsamCUaqmZPhgB56AMVOBpCk7x5SxTmc5dw=; b=QSKhoyQpaAWTkj3AjwNwZlH/nAxYyqRTlFguv0TlKU/tUFmMv2N+/eDhiI/CEKLsRO //Drzq/2N7x1slEGOZlXmt2B/nEGcDJoitHJJlBqkh0lyGOBWGAvG5V5Q7ulbSKVdrMA zR1BFsdCpJjNfQ4ltNMwiuDxrjZsHsyvq+QkN0DWv8AZVBjf3NqNhxVgUhyTYCgbn5vW ykb2628401o43OzdcpabENZZiFsmXFCNWSGfN+1cfjkYqC3WkERXDrj1EvCIKwlxm1Sz F1FP5BqvAdn/2GDa30ERaAwrQ9rLTLSqA1/A6CZgNF0lq7dOSaM/aM2RXg09sBEqPEY/ 12Og== X-Gm-Message-State: AOAM53388GAjQmN7bbVs+CgYlrgkDDABfm+TIUGNrYN7DNY8yb2+m7vf tsuAYh9jBaGEmgnAP0FlfBQtB5nqtrU= X-Google-Smtp-Source: ABdhPJzdLFO1PJRQfagvdu7C5L7BxXpvqH3UAZ/FpCltSXD4sZPnB2J7VK1pXgxihAnwWCiBf2E0YA== X-Received: by 2002:ac8:4783:: with SMTP id k3mr23773888qtq.303.1596560923071; Tue, 04 Aug 2020 10:08:43 -0700 (PDT) Original-Received: from mt-manjaro (216-58-109-18.cpe.distributel.net. [216.58.109.18]) by smtp.gmail.com with ESMTPSA id p123sm21098308qkd.26.2020.08.04.10.08.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Aug 2020 10:08:42 -0700 (PDT) In-reply-to: <87lfiuu836.fsf@gnus.org> Received-SPF: pass client-ip=2607:f8b0:4864:20::830; envelope-from=matthewzmd@gmail.com; helo=mail-qt1-x830.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253442 Archived-At: Lars Ingebrigtsen writes: > "Mingde (Matthew) Zeng" writes: > >> I had a look at Lars' change, that particular commit simply changes >> target to (not target), it is not enough to fix the problem entirely >> (as outlined in my commit message). Also, changing to (not target) >> technically does avoid this specific problem, but imo it logically >> doesn't make sense. When invoking `erc-generate-new-buffer-name`, >> target is not an optional parameter and should never be nil, that line >> is unnecessary amd therefore removed from my commit. > > The only usage of that function is (indirectly) from here: > > (defun erc-open (&optional server port nick full-name > connect passwd tgt-list channel process) > > [...] > > (buffer (erc-get-buffer-create server port channel)) > > So I assumed that target could indeed be nil -- especially since that > function has always checked whether target is nil or not, only that the > previous check was reverse of what it should have been. Okay that sounds right, I'll rebase my patch. > >> I have another question, since I've never contributed to Emacs >> directly before, can you tell me is there any way to quickly find out >> whether a bug is tracked by GNU bug reports or not? > > The bug tracker has a search field, if that's what you're asking? I see, found it. Also, is there a way to respond to a bug (i.e https://debbugs.gnu.org/cgi/bugreport.cgi?bug=40121) without subscribing to bug-gnu-emacs? I cannot find a "Comment" button similar to a bug-tracking site like bugzilla (which is what i'm more familiar with). Really like to avoid multiple people working on the same bug in the future. -- Mingde (Matthew) Zeng