From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Tests and linting not coupled to one file Date: Sat, 26 Sep 2020 15:38:17 +0200 Message-ID: <87sgb4lkty.fsf@gnus.org> References: <20200925124646.29315.84502@vcs0.savannah.gnu.org> <20200925124647.83150209D4@vcs0.savannah.gnu.org> <87y2kynf4n.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9556"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 26 15:39:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMAPm-0002NG-3E for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Sep 2020 15:39:02 +0200 Original-Received: from localhost ([::1]:54182 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kMAPl-0004fo-3r for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Sep 2020 09:39:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49788) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMAPC-0004GE-8b for emacs-devel@gnu.org; Sat, 26 Sep 2020 09:38:26 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:41576) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kMAPA-0002Jb-FT for emacs-devel@gnu.org; Sat, 26 Sep 2020 09:38:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=maEs085F6reiGP/83gVtcVWhT3WM4gQUFQR7pzHF5dU=; b=VEX7HlXVlmLoaRr1RNMzYQAlBn lilPxYYXwsJRo/3r4TFU+6EX2Xhp3GvMMNX4Ls/U6uQOSALzrZZklGBcZyFN+MSmW9/81IYkBRxhV iCDuSZrVxg341CTmlnBDQwW199rcbcA6R/3THLh7IN0zhv1Au6mVfwrRcmJRqujdbbkc=; Original-Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kMAP5-0007hR-B8; Sat, 26 Sep 2020 15:38:22 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEVkXmgqHh6IeYig ZFK2hXRodYahjZr///+30dEnAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QJGg0eHLst1n0AAAFySURB VDjLhZNLjoMwEEQLIu8zN0AeyJqRcwN8AMuSLxAh7n+E6Z/BIYnSG6R+dFV/AJD4eQl8AfgE+tC9 B2MM8wdwJpp3a4xLwCsoAubuBFzJb4ErAmJ46gwJhUJBay/pUrgrCryAHNmkLTGQLkGiO4Pb8gdm 8wnkja2JHB0bWGkjgAE0YCRnmMlVjmAghjt3JQDipMAvBGRG0C4OwEp3nYTApQUkIgXUwiU0UolS d1mKtCAd2EqWoOZh1oIK0mh5HkevoaDYrkgK8r6C5Io/APSuqkRb3JXQXV0RkORSSy1AR70mruHr GpgrKPbBlbw7hBa427ZagaqJSYLbNNal2qBQUfY3A5sYVZD3NIHYAt+CZfegKx0lq9xKhuMKIQ8D 9Df4UoFnNX54voqfkkpV9ODH7+htZm+Eax5+AgZM2hct3e8xoKc3Br5HcnSMlpDmwHNQ5JolmwGe 1WyFuSlBE1VrKHgON1HJhH7COfqzBv2y/6/ZsvIPFQRFAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIw LTA5LTI2VDEzOjMwOjI4KzAwOjAwnZ+grwAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0wOS0yNlQx MzozMDoyOCswMDowMOzCGBMAAAAASUVORK5CYII= X-Now-Playing: Jane Siberry's _The Walking_: "The Walking (And Constantly)" In-Reply-To: (Stefan Kangas's message of "Fri, 25 Sep 2020 15:36:31 +0000") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256455 Archived-At: Stefan Kangas writes: > That's a fair point. Likely they would not be aware of "test/misc" at > first. OTOH we could document it in "test/file-organization.org". > > Here's three scenarios where adding a test to the existing files might > not make sense: [...] > That said, if we can find a way to shoe-horn the stuff we need into the > existing test suite without it being overly ugly, it's perfectly fine by > me. Perhaps that would be less ugly than adding a new "test/misc" > directory. There's certainly something to be said for consistency here: If we're looking for a test of something in foo.el, we look in lisp/foo-tests.el. And as you point out, cross-cutting linter stuff doesn't really fit into that scheme at all. So upon further consideration, I agree with you that adding a test/misc directory would be better in the long term. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no