From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: master 5065698: Move the =?utf-8?B?4oCYZGVjbGFyZeKAmQ==?= form before the interactive spec in 10 functions. Date: Sat, 23 Jan 2021 19:33:46 +0200 Organization: LINKOV.NET Message-ID: <87sg6ra7cp.fsf@mail.linkov.net> References: <20210120191935.5488.54008@vcs0.savannah.gnu.org> <20210120191936.DCB55209AB@vcs0.savannah.gnu.org> <87r1mfl3r5.fsf@gnus.org> <87h7nbs34v.fsf@mail.linkov.net> <87eeifqnve.fsf@mail.linkov.net> <87im7ruu92.fsf@mail.linkov.net> <874kjazlda.fsf@mail.linkov.net> <87v9bp7wft.fsf@mail.linkov.net> <8735yte4oy.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20125"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jan 23 18:34:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l3MoM-00056C-Fa for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 18:34:58 +0100 Original-Received: from localhost ([::1]:53838 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l3MoL-0002fP-Ck for ged-emacs-devel@m.gmane-mx.org; Sat, 23 Jan 2021 12:34:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Mnl-0002FU-EO for emacs-devel@gnu.org; Sat, 23 Jan 2021 12:34:21 -0500 Original-Received: from relay10.mail.gandi.net ([217.70.178.230]:57451) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l3Mni-0001ov-4h for emacs-devel@gnu.org; Sat, 23 Jan 2021 12:34:21 -0500 Original-Received: from mail.gandi.net (m91-129-98-64.cust.tele2.ee [91.129.98.64]) (Authenticated sender: juri@linkov.net) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 626E0240007; Sat, 23 Jan 2021 17:34:13 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Fri, 22 Jan 2021 09:04:44 -0500") Received-SPF: pass client-ip=217.70.178.230; envelope-from=juri@linkov.net; helo=relay10.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:263306 Archived-At: >> The GNU Coding Standard format requires a line number between colons, >> so maybe count-lines would give some plausible number in most cases. > > But 0 would work as well for that purpose. I don't know if this is the best that could be done: diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el index 0f8dd5a284..a2cbb85412 100644 --- a/lisp/emacs-lisp/byte-run.el +++ b/lisp/emacs-lisp/byte-run.el @@ -301,7 +301,7 @@ defun (cdr body) body))) nil) - (t (message "Warning: Unknown defun property `%S' in %S" + (t (message "unknown:0:Warning: Unknown defun property `%S' in %S" (car x) name))))) decls)) (def (list 'defalias >>> Another approach could be to use something like >>> `macroexp--warn-and-return`. >> `macroexp--warn-and-return` uses `load-file-name` that is nil here. > > Not necessarily, no: when compiling, it will let bytecomp.el emit the > warning which gives proper file and line numbers. > > Do we care about the format used when we're not compiling? > [ This is not a rethorical question. ] Indeed, this format is useful only when compiling. >> I tried it, but it has no effect. >> >> (let ((warnfun (lambda () >> (message "Warning: Unknown defun property `%S' in %S" >> (car x) name)))) >> `(progn >> (macroexp--funcall-if-compiled ',warnfun))) > > How did you try it? Compiled this, then tried to byte-compile a file with wrong `declare`, still same warning without line numbers.