From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: scratch/command 064f146 1/2: Change command to interactive ... modes Date: Sat, 20 Feb 2021 16:01:24 +0100 Message-ID: <87sg5qn5q3.fsf@gnus.org> References: <20210213141225.11309.86562@vcs0.savannah.gnu.org> <87zh07of0e.fsf@gnus.org> <0605ed62-a785-d190-caf2-2232e1db3b0f@yandex.ru> <87mtw6d480.fsf@gnus.org> <87eehid3k2.fsf@gnus.org> <87r1liblzb.fsf@gnus.org> <87czwy1mu2.fsf@gnus.org> <87wnv5y8bn.fsf@gnus.org> <87sg5ty838.fsf@gnus.org> <87lfbkuup8.fsf@gnus.org> <871rdark7d.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37481"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Dmitry Gutov , Stefan Kangas , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Feb 20 16:02:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDTmK-0009fD-Gs for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Feb 2021 16:02:40 +0100 Original-Received: from localhost ([::1]:52086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lDTmJ-0004py-Ia for ged-emacs-devel@m.gmane-mx.org; Sat, 20 Feb 2021 10:02:39 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60452) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDTlE-0003p3-1j for emacs-devel@gnu.org; Sat, 20 Feb 2021 10:01:32 -0500 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:34400) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lDTlC-00013h-FY for emacs-devel@gnu.org; Sat, 20 Feb 2021 10:01:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=CIpfzauXpN2D2jXmStMLyFdB3XmgEAEoUb/Vj+sScyY=; b=KHx+kPNb63D2JQScYoMuVA7RGD 1WqjkuBfhKhAuJuXCXDKit3DtgCwrZm0wtlASddzMncZrgwYSwu21mzBmFhxzeRixvkt0rr208zy+ fGxQouKlCSZkAerVsjIVRrysdO88hOMUE6hx0hga7rhK2oFCT8I/PgWHdwHAl/1wpEkQ=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lDTl8-00079r-1r; Sat, 20 Feb 2021 16:01:28 +0100 X-Now-Playing: White Heaven's _Levitation_: "Snow On The Table -remastered edition 2021-" In-Reply-To: (Stefan Monnier's message of "Sat, 20 Feb 2021 09:38:23 -0500") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: 6 X-Spam_score: 0.6 X-Spam_bar: / X-Spam_report: (0.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, GUARANTEED_100_PERCENT=2.699, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:265328 Archived-At: Stefan Monnier writes: >>> You'll need to adjust the Edebug specs of `defun` (there are probably >>> other ways, of course) if you want to fix that. >> You mean add "future-interactive" as an alternative in the spec? > > Yup: the spec is all about instrumenting the source code as-is (before > macro-expansion). OK, so if we do include future-interactive as a core GNU ELPA package, then the following 100% guaranteed untested patch should make this work in Emacs 28. diff --git a/lisp/emacs-lisp/edebug.el b/lisp/emacs-lisp/edebug.el index 45e76c751f..8a5960bb28 100644 --- a/lisp/emacs-lisp/edebug.el +++ b/lisp/emacs-lisp/edebug.el @@ -2088,7 +2088,8 @@ edebug-match-def-body ;; more convenient to define their Edebug spec here. (defun ( &define name lambda-list lambda-doc [&optional ("declare" def-declarations)] - [&optional ("interactive" &optional [&or stringp def-form] + [&optional ([&or "interactive" "future-interactive"] + &optional [&or stringp def-form] &rest symbolp)] def-body)) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no