From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 695f679: Remove ; ; ; ###tramp-autoload cookie from Tramp defcustoms (Bug#47063) Date: Sun, 14 Mar 2021 09:39:30 +0100 Message-ID: <87sg4ygmd9.fsf@gmx.de> References: <20210313133546.6042.78482@vcs0.savannah.gnu.org> <20210313133547.AA06C20B2E@vcs0.savannah.gnu.org> <877dma1yfv.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37435"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: "Basil L. Contovounesios" , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 14 09:40:17 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lLMIK-0009ft-PG for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Mar 2021 09:40:16 +0100 Original-Received: from localhost ([::1]:54776 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLMIJ-0000ao-RR for ged-emacs-devel@m.gmane-mx.org; Sun, 14 Mar 2021 04:40:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLMHm-0000Ax-BL for emacs-devel@gnu.org; Sun, 14 Mar 2021 04:39:42 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:45463) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLMHj-0003ey-6Z for emacs-devel@gnu.org; Sun, 14 Mar 2021 04:39:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1615711172; bh=Mc0HvaLfu+J2i3wKIUq0QJhv06r2ycw0adnz3XgZ5JU=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=eZzEY7napK9jwsMGzXaxQ5S88nLBuUglS4pQkK/+UaHZ/7vSTIVOGk+AyYcBYMH9u KE7ttOF1kKvTzQDdCVYLK7V4HeyKfmg7cdtQVxt2XsAr2EaePhMc1ic+4GVGkTSfA7 OuP4c6nGRv2+akFo6bPWrfhkkA7ATyvlkuz2OBHY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([212.86.53.226]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MHoRK-1lY3sI1Ive-00EtFH; Sun, 14 Mar 2021 09:39:32 +0100 In-Reply-To: (Stefan Monnier's message of "Sat, 13 Mar 2021 18:20:00 -0500") X-Provags-ID: V03:K1:7b/uRAInYhEIki8X4q2mqcO9xke4WgVxdgk+57/z0QELBVKVYV1 Q6FjynP84d/jIiLeNvxu4IrSUq7rlDXheCQ9fo6yP/vzje4g1LmFBMFMnIA/vxHf/vqzQ52 psAT2drzUjIiANeFBB/nY7m3rTBHzI+PaWC2wAwlHeiSjWnqQZFO9jWGn9zkSaygqiFsUO1 OAMdslN4bcOtnHKQgBUSA== X-UI-Out-Filterresults: notjunk:1;V03:K0:T//FC7CQ+kA=:3EJApP67z5ACUL5etIPnZw uLa4WY9ALmpcyFTHpwig8YOgkfDul3UhCFKAPwaTOy3fM0UZazlC6I/hzZ9f3i9HHXgOlEUww qT7pslbS1wUJfOCe6jm0yZdhmEcaVTBLXxzGnNk92RslPeXOR4Sldfu3wY8bys7BYX9EU0oWV JBtmdR7xJuVyr/Hnj8AOT3H6StV/fH+gbMu6Kj7xg8SJ17jDSmkdh1rJlRq1bBQWlBq0sRWSp vaS68MsBdKYLZihEvmMoo7nBiI5As56MefAWRefYPlYNk+YtwrwiZ3SDlwsYiqYjvfC/aIYnL 2jNIK25Ig3rEjtybIRCIK2dWXpbfOHKAIL2AnkkZ365Zo8nMWC1bTD9AbBpHTGiYqw2rX2pcH iWsj5AZsILV0XbtjAOmOMvxNQs+VOK7iP74BEBGzknthol5gUT+oxwLg8M0Pf/k+m5ukETn6p 1Zdz+fJfL+7i1hFSqm0OCQuZANr5jbCh9YBIC8BF3dBYfHXrYl5NRYR3SPQGScu5FBWJYzaGi cCtE++8qTlAbeur7HFVzWnlE2/ZjV2A0TTEPkQUnqWLhr5qfmQR/b9suDhRfw0bYRMAwF2x7J RvYADnS+4/xanwNYleFK4K8pehZQslvommxIF7gAs8zVzln2xlgIxwesgGWtaW93oOZ9Yxb66 U8tPLVoqGzFF/e80jC39jKyXkbKLfsgawVTC1wcPwPaY1j3SzZd84+mjl3PAmu/ShxwCwhLH5 BtbYvWM3QB5Mek3fjUPnWhV7Of+vYGVS6xkiVsk6VpW7x1oJR2+rU/rzlhdSH7dShRqhvHfh Received-SPF: pass client-ip=212.227.17.22; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:266450 Archived-At: Stefan Monnier writes: Hi Stefan & Basil, >> My question is, which combination of the following should happen: >> - The completion-predicate properties are not autoloaded. > > This means that autoloaded functions will always be listed in `M-x` > (except after loading the corresponding package), which is undesirable. Calling `tramp-crypt-add-directory' interactively is the only way to activate package tramp-crypt.el. As long as the package isn't loaded yet, this command must be visible. >> - The function tramp-crypt-enabled-p is autoloaded. > > Sounds good. No, because otherwise tramp-crypt.el would be loaded unconditionally due to the command completion of `tramp-crypt-enabled-p'. >> - The function command-completion-default-include-p checks whether >> completion-predicate is functionp. > > I think this is *also* needed, tho a better option is > `with-demoted-errors` since no matter what error is signal'd we don't > want it to prevent `M-x` from doing its job. Yes. I have adapted tramp-crypt.el such a way, that `completion-predicate' for `tramp-crypt-add-directory' is set only after loading tramp-crypt.el. > Stefan Best regards, Michael.