From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Date: Fri, 07 May 2021 20:03:48 +0300 Organization: LINKOV.NET Message-ID: <87sg2ymq6j.fsf@mail.linkov.net> References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32642"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: Gregory Heytings , "emacs-devel@gnu.org" , Stefan Monnier , Dmitry Gutov To: Daniel Mendler Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 07 19:21:53 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lf4Ai-0008P5-W0 for ged-emacs-devel@m.gmane-mx.org; Fri, 07 May 2021 19:21:52 +0200 Original-Received: from localhost ([::1]:53200 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lf4Ai-0004Xj-0f for ged-emacs-devel@m.gmane-mx.org; Fri, 07 May 2021 13:21:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44292) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf44U-0000cA-GG for emacs-devel@gnu.org; Fri, 07 May 2021 13:15:28 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:49181) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lf44N-0004C3-Ct for emacs-devel@gnu.org; Fri, 07 May 2021 13:15:24 -0400 X-Originating-IP: 91.129.102.166 Original-Received: from mail.gandi.net (m91-129-102-166.cust.tele2.ee [91.129.102.166]) (Authenticated sender: juri@linkov.net) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 650B1C0007; Fri, 7 May 2021 17:15:11 +0000 (UTC) In-Reply-To: <878s4w3law.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 03 May 2021 00:38:05 +0300") Received-SPF: pass client-ip=217.70.183.198; envelope-from=juri@linkov.net; helo=relay6-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269009 Archived-At: >>> (let* ((enable-recursive-minibuffers t) >>> (completion-ignore-case t) >>> (completion-tab-width 4) >>> (completions-group read-char-by-name-group) >>> ======================= >>> (input >>> (completing-read >>> prompt >>> (lambda (string pred action) >>> (if (eq action 'metadata) >>> `(metadata >>> (group-function >>> . ,(when read-char-by-name-group >>> ======================= >>> #'mule--ucs-names-group)) >>> >>> The same user option read-char-by-name-group is checked twice. >>> It should suffice to leave only the latter. >> >> This is a matter of preference. In this case I think I would prefer to >> have the settings checked only once centrally in order to avoid the code >> duplicatication in every completion table. Furthermore it seems that the >> style to check the setting locally in every completion table will lead >> to an unnecessary proliferation of configuration variables, since you >> introduced the variable `read-char-by-name-group` here. I don't think we >> should introduce an extra configuration variable per completion table. > > I agree, `read-char-by-name-group` is obsolete by your new option > `completions-group`. I tried to remove `read-char-by-name-group`, but it has a feature currently not supported by `group-function`: (defcustom read-char-by-name-group nil "How to group characters for `read-char-by-name' completion. When t, split characters to sections of Unicode blocks sorted alphabetically." ===================== It seems a new function is needed to sort groups, e.g. `group-sort-function`. Maybe better to push your current patches, so it would be easier to base the next patches on master?