unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, akrl@sdf.org
Subject: Re: Some native compiler related renaming
Date: Sat, 08 May 2021 18:01:42 +0100	[thread overview]
Message-ID: <87sg2xkvm1.fsf@tcd.ie> (raw)
In-Reply-To: <835yzt9qcv.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 May 2021 18:50:40 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: "Basil L. Contovounesios" <contovob@tcd.ie>
>> Cc: Andrea Corallo <akrl@sdf.org>,  emacs-devel@gnu.org
>> Date: Sat, 08 May 2021 16:03:50 +0100
>> 
>> No bonus points for me please, only some nits.  How's this:
>
> Thanks.  I don't agree with some of your changes:

Sure, that's why I wanted to check with you first.

>>    If Emacs was compiled with support for native compilation
>> -(@pxref{Native Compilation}), then when a @samp{.elc} byte-compiled
>> +(@pxref{Native Compilation}), then when a @file{.elc} byte-compiled
>>  file is found by searching @code{load-path}, Emacs will try to look
>> -for a corresponding @samp{.eln} file holding the corresponding
>> +for a corresponding @file{.eln} file holding the corresponding
>
> The text uses @samp elsewhere for file-name extensions, so I wanted to
> be consistent.

Fair enough; it seemed to me like most of those occurrences in the
affected sections were talking about constructing file names.

>> -system directory, i.e.@: the directory with @samp{.eln} files
>> -installed by the Emacs build and installation procedure.  In each of
>> -the directories in the list, Emacs looks for @samp{.eln} files in a
>> +system directory, i.e., the directory with @file{.eln} files installed
>
> I VERY much dislike using a comma after "i.e.".

I do too, but I thought that was the preferred US convention.

Pushed with the objectionable parts removed.

Tiny fixes to recent native compilation docs
bb8b8d717f 2021-05-08 17:53:41 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=bb8b8d717f91a85ca41de9e82246e6975e1ed719

Thanks,

-- 
Basil



  reply	other threads:[~2021-05-08 17:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 15:17 Some native compiler related renaming Andrea Corallo via Emacs development discussions.
2021-05-08 13:30 ` Eli Zaretskii
2021-05-08 15:03   ` Basil L. Contovounesios
2021-05-08 15:50     ` Eli Zaretskii
2021-05-08 17:01       ` Basil L. Contovounesios [this message]
2021-05-08 21:28   ` Alan Mackenzie
2021-05-09  6:49     ` Eli Zaretskii
2021-05-10  7:42   ` Andrea Corallo via Emacs development discussions.
2021-05-11  8:40   ` Andrea Corallo via Emacs development discussions.
2021-05-11 12:26     ` Eli Zaretskii
2021-05-11 16:33       ` Andrea Corallo via Emacs development discussions.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sg2xkvm1.fsf@tcd.ie \
    --to=contovob@tcd.ie \
    --cc=akrl@sdf.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).