From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Cleaning up rcirc Date: Thu, 10 Jun 2021 15:50:46 +0000 Message-ID: <87sg1pwwfd.fsf@posteo.net> References: <874kedu0cm.fsf@posteo.net> <877dj94liu.fsf@igel.home> <87im2tlcwy.fsf@posteo.net> <87sg1urfwu.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21917"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Andreas Schwab , emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 10 17:52:24 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lrMym-0005Yv-Hm for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Jun 2021 17:52:24 +0200 Original-Received: from localhost ([::1]:49724 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lrMyl-0003ss-8Y for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Jun 2021 11:52:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrMxK-0001nY-M2 for emacs-devel@gnu.org; Thu, 10 Jun 2021 11:50:55 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:58285) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lrMxI-0007Wc-3l for emacs-devel@gnu.org; Thu, 10 Jun 2021 11:50:54 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id B92A72400FC for ; Thu, 10 Jun 2021 17:50:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1623340247; bh=6fgu4vYBqlq8jPUOPzCabkTV69/rOwyRFALNS1Q/0nc=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=Dyg0n7wHrV7FR17K9PFWESqZEdbI8WQd8yTz3h1B/gAB25hAuHL9cEL1IE2QeEWZG m5QWi1MvrGY9/u3x1sTDUyzmXeEsEsGV61GvdE2sEJ2b+qHRmeOB6WECy3yKy30CXL 4S7HnBGicvEvaf25uYQJo7brKs4oG0GqodUZfpl0fYyC3ZFg0XQgfIJafzUqfE+ngA /HU+P4AR5zuXaKyanwuEsX5oPF1AJxXXbnpGWwZ1yKxFalQN1+ZWuQbP+vZj0kUQ8K ILto9TRejRozAKP2Y0i0PaGcSptlII/q2CYAqTgwsPz7tYe363IpsnTNpUGBr8yTdY UL+dnMJo3uAuw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4G17jg13GZz9rxL; Thu, 10 Jun 2021 17:50:47 +0200 (CEST) Autocrypt: addr=philipk@posteo.net; prefer-encrypt=mutual; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB In-Reply-To: <87sg1urfwu.fsf@gnu.org> (Tassilo Horn's message of "Sun, 06 Jun 2021 20:41:41 +0200") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270650 Archived-At: Tassilo Horn writes: > Philip Kaludercic writes: > >> Either way, I also noticed there were other issues with the code, that >> I have since fixed. Would it be ok to push the changes as a feature >> branch, so that I don't have to re-send all the patches again and >> again? > > IMHO, yes. It would also make testing much easier. I'm a rcirc user so > I'd be happy to give it a whirl. Just pushed the changes to feature/rcirc-update. I rewrote the commits and remove the define-derived-mode change, because that broke requiring more refactoring to fix. A few IRCv3 specs have already been implemented, as listed in the new option rcirc-implemented-capabilities. I plan to add these sooner or later: - https://ircv3.net/specs/extensions/account-notify - https://ircv3.net/specs/extensions/account-tag - https://ircv3.net/specs/extensions/extended-join - https://ircv3.net/specs/extensions/away-notify - https://ircv3.net/specs/extensions/echo-message - https://ircv3.net/specs/extensions/labeled-response - https://ircv3.net/specs/extensions/multiline - https://ircv3.net/specs/extensions/sasl-3.1 and - https://ircv3.net/specs/client-tags/reply - https://ircv3.net/specs/client-tags/react - https://ircv3.net/specs/extensions/chathistory as soon as they become reliable. I have experimented with chathistory, and in principle it works. What this would also require is a proper UI to allow general queries. What is doable now is something like "request the last 20 messages right after joining a new channel", and they will be printed with the right timestamps. -- Philip K.