From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.devel Subject: Re: Context menus and mouse-3 Date: Tue, 13 Jul 2021 02:56:27 +0300 Organization: LINKOV.NET Message-ID: <87sg0jt7bo.fsf@mail.linkov.net> References: <20200914061111.3trmuzhdvv7nwdcc@Ergus> <87y2acv2tw.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17472"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) Cc: philipk@posteo.net, Richard Stallman , spacibba@aol.com, emacs-devel@gnu.org, arthur.miller@live.com, dgutov@yandex.ru, ghe@sdf.org, drew.adams@oracle.com To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jul 13 02:03:10 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m35tF-0004QG-48 for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Jul 2021 02:03:09 +0200 Original-Received: from localhost ([::1]:34896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m35tD-0002zt-Tx for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jul 2021 20:03:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42472) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m35rW-0000jn-7G for emacs-devel@gnu.org; Mon, 12 Jul 2021 20:01:22 -0400 Original-Received: from relay7-d.mail.gandi.net ([217.70.183.200]:35325) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m35rT-0004fH-I3; Mon, 12 Jul 2021 20:01:21 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 7212B20005; Tue, 13 Jul 2021 00:01:10 +0000 (UTC) In-Reply-To: (Stefan Monnier's message of "Mon, 12 Jul 2021 18:32:17 -0400") Received-SPF: pass client-ip=217.70.183.200; envelope-from=juri@linkov.net; helo=relay7-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271190 Archived-At: >> The global binding of [menu-bar] is defined in menu-bar.el, >> so the same way [context-menu] could be defined globally > > Agreed, and I think it would address the above problem. > I.e. do something like > > (defun mouse-context-menu (event) > (push `(context-menu . ,(cdr event)) unread-command-events)) OT1H, this avoids an explicit call to 'popup-menu'. But OTOH, this precludes constructing the context-menu with a user-defined function mouse-context-menu-function. I tried to override the global [context-menu] with e.g. menu-bar-custom-menu (that later could be replaced with the value returned from mouse-context-menu-function): (let ((map (make-sparse-keymap))) (define-key map [context-menu] menu-bar-custom-menu) (set-transient-map map)) (push (cons 'context-menu (cdr event)) unread-command-events) However, it doesn't override the global [context-menu], but prepends the transient [context-menu] before the global one. > PS: FWIW, the "proof of concept" code I have in my local Emacs is: [...] > I think `sit-for` can be made to work OK, but my proof-of-concept > isn't good enough. I think the main issue is that it doesn't > swallow the mouse-3 click, but I haven't really looked into it. At least, now we have two implementations, and both could be improved before selecting the one that works better. Meanwhile, I'd continue trying to combine [context-menu] with mouse-context-menu-function.