From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: bug#49822: master e32c7d2: Change Python eval to send directly instead of using temporary files Date: Tue, 07 Sep 2021 19:59:06 +0200 Message-ID: <87sfygl11x.fsf@gmail.com> References: <20210903122828.16890.65271@vcs0.savannah.gnu.org> <20210903122829.EAAC220B71@vcs0.savannah.gnu.org> <87r1e4eklw.fsf@gmail.com> <87v93fnfmm.fsf@igel.home> <87lf4aooge.fsf@gmail.com> <878s0a409g.fsf@gmx.de> <87ilzef65i.fsf@igel.home> <878s0aeyna.fsf@gmx.de> <87r1e1ex7z.fsf@igel.home> <875yvcmgm2.fsf@gmail.com> <83y288nuoq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30966"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: andrewjmoreton@gmail.com, Mark.Barton@disney.com, emacs-devel@gnu.org, schwab@linux-m68k.org, monnier@iro.umontreal.ca, 49822@debbugs.gnu.org, michael.albinus@gmx.de, larsi@gnus.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 07 19:59:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mNfO2-0007mq-Mb for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Sep 2021 19:59:58 +0200 Original-Received: from localhost ([::1]:33464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mNfO1-0002bl-6y for ged-emacs-devel@m.gmane-mx.org; Tue, 07 Sep 2021 13:59:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mNfNH-0001lD-Eq for emacs-devel@gnu.org; Tue, 07 Sep 2021 13:59:11 -0400 Original-Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]:45848) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mNfNF-0004s4-Pz; Tue, 07 Sep 2021 13:59:11 -0400 Original-Received: by mail-ej1-x629.google.com with SMTP id e21so21258680ejz.12; Tue, 07 Sep 2021 10:59:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kcHrW/WGr2OsJ5ODSg/ya2BRiyjWnS9NBtoH0p1XbkM=; b=iNRnyT1NDJyIYGmjSVXbRQV5s79xoFSYZi4YKfSXWKn8BDD+IlmXjpcHq1vkA7q5cD MnwRXlm2f8jF3qs3ZDrJ9kephhdurOjGBakxdTa7MaadCLsHoJ1F+tPtFL23Gw+FVlWt e3ll41AkK09wzBbW4TgkT1FdOeXSqoKGo0HOlxS3pvgH+3xlAhV1LPfEaPdpHR86UKrR +sQEaJeYv1TJQKtOnJ+5skRNmup+xPn/d6f8AYefzT1g/4xFnIlOIB4XJKKdIKanX61m rg4Wc6VmWbktx9uLJGIifbrySe6FiW1SEiz9nE4d46wSEefzAJLiS9egcxAuam0a5w1n lhJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kcHrW/WGr2OsJ5ODSg/ya2BRiyjWnS9NBtoH0p1XbkM=; b=Yus6hretAOYVK4F+WWzG1m0sfGHEaVcicICw2V4NbeH4zZe8nLpb5eV4Ub5/rGkmp/ G9CxxmyVdjFPz7qms39K0Ip4FQRswsEh4IfuG9JubHubk+8OJAfEOCzo6dxqhT0oUC61 HGE3szpWAtORU0wTDHVIU59BGLD1jxJU1O6pKJ1pEJ7AxCg4uD80DiZ/X/eNn/QNwm2Z 2G9OfdhcXNlMsaAXuTboQgqw7mbBbXOmI3G0h24ZzDTvPh41NxFG1Npa0ON6doZV+OEu sZ/4VfSLLbQuhzuJmPvCb8XcmLVuNZKziXJ8dDUCts0gQRi6+lOlVXQCGjAFwmoXIPfd quAw== X-Gm-Message-State: AOAM530k9p+9ntX8OKXRnQssBSi5U5UUyCptcJIosJcpGtsV/McVtBmR mhnCvvXpDKH62xxUuNo2CMA= X-Google-Smtp-Source: ABdhPJzDY5r6/ew4knAcuwtEd8sBl0OdqUOY6ciJSFqoMt4htAe54KBGzhsXS/wmIS7q0Gg72vLUEQ== X-Received: by 2002:a17:907:c10:: with SMTP id ga16mr20329955ejc.174.1631037547726; Tue, 07 Sep 2021 10:59:07 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::b1d]) by smtp.gmail.com with ESMTPSA id l24sm416699edq.36.2021.09.07.10.59.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Sep 2021 10:59:07 -0700 (PDT) In-Reply-To: <83y288nuoq.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 07 Sep 2021 20:48:21 +0300") Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x629.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:274278 Archived-At: On Tue, 7 Sep 2021 at 20:48, Eli Zaretskii wrote: >> From: Augusto Stoffel >> Date: Tue, 07 Sep 2021 19:37:41 +0200 >> Cc: Andy Moreton , emacs-devel@gnu.org, >> Andreas Schwab , >> Stefan Monnier , 49822@debbugs.gnu.org, >> Michael Albinus , Lars Ingebrigtsen >> >> Okay then. Since there seem to be no better alternatives, I have >> attached a new patch reducing the limit to a hard-coded 1024 bytes. If >> some day someone adds a variable specifying a more precise limit, then >> we can change this. > > I thought the conclusion was that we do know the limits, but they are > different on different OSes? If so, why not use the correct limit for > each OS, instead of using the most strict limit? The underlying OS is > available in system-type. > >> - (if (<= (string-bytes code) 4096) >> + (if (<= (string-bytes code) 1024) > > In any case, IMO this should be a defconst with a suitable doc string, > so that we'd have this stuff documented for posterity. > > Thanks. Yes, I agree this should be a defconst, defined in comint.el or maybe even in C, if there turns out to be a sensible way to query the OS. I'm afraid I've already proved that I am not up to this particular task :-)