From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS Date: Wed, 16 Feb 2022 22:49:00 +0000 Message-ID: <87sfsizaub.fsf@posteo.net> References: <164484721900.31751.1453162457552427931@vcs2.savannah.gnu.org> <20220214140020.04438C00891@vcs2.savannah.gnu.org> <87bkz9tbcj.fsf@posteo.net> <87o839ypx6.fsf@posteo.net> <87mtisnjcb.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24742"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 17 00:00:25 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKTHc-0006Ek-Mk for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Feb 2022 00:00:24 +0100 Original-Received: from localhost ([::1]:57826 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKTHb-0008JN-I8 for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Feb 2022 18:00:23 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKTF3-0006EF-Vp for emacs-devel@gnu.org; Wed, 16 Feb 2022 17:57:46 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:38389) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKTF0-00057L-Cv for emacs-devel@gnu.org; Wed, 16 Feb 2022 17:57:45 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 181EB240101 for ; Wed, 16 Feb 2022 23:57:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1645052260; bh=futBHDOd74+P4Y4hcyy8t1iCbxfAkfHTBAO/s5kQukE=; h=From:To:Cc:Subject:Date:Autocrypt:From; b=OQJbPgCGt+ee2Y/CTLxyM20zxH6aivPePxT6Um014Ey53aEzcYnur1rnGJ+MeRo/u YsXVk4GNiVC7qQhBeOHHj5z7fAxeOqkOnlLkAwbpJ50RzIf1P/sG0RVyhEOiOplYrj 07JYOkTpaaLOFN1ZdWY9GoFBhgXARsnKDRLPbASs8hUF6mNBADYdoS9yBkBmq42zwU siOdN+Vz0X2kTfZ4XA4Kjk9cs/K/KHwKohMgxk9ICutcrcm77g9GnPj2cO2EzmKZdk fH4TgB0kIhAxsfwOICNVTpZYzaUAspzPex//xGJILpPHz/rwess7PODiTqdsJaqyXF PDTizaQg87sdQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JzYJM2Lclz9rxF; Wed, 16 Feb 2022 23:57:39 +0100 (CET) In-Reply-To: (Stefan Monnier's message of "Tue, 15 Feb 2022 13:34:37 -0500") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286405 Archived-At: Stefan Monnier writes: > Philip Kaludercic [2022-02-15 17:13:56] wrote: >> Stefan Monnier writes: >>>> The -devel doesn't necessarily indicate that directly, I just meant it >>>> was worth somehow explicitly indicating that this is a VCS-package. >>> But what I'm saying is: why not put no "-*" at all, since that's what >>> `package.el` has been using so far for those cases (tho these had to be >>> "installed" by hand)? >> I get that, my question still remains. Or to rephrase it, what is the >> advantage of displaying package names with the same names as the >> directories they are found in? > > Not sure what "display" has to do with it. The name of the package is > beyond our control. So the choice is not what to display but what name > to give to the directory. `` is a name that already works. > `-devel` is a name that currently doesn't work. > > In any case, this is not an important issue, I think (at least, as long > as "devel" is not a valid version name). I now understand the confusion, I had assumed we were discussion how package names are presented by completing-read calls, without considering that `package-desc-full-name' is invoked elsewhere too. In that case, yes, the change should be reverted. >>>>> IIUC for those VCS-installed packages we generate the -pkg.el file >>>>> ourselves, so it should be fairly easy to make sure that file provides >>>>> the needed info so we don't need to guess. >>>> >>>> Yes, but again, if I just clone a project into elpa/devel, this won't >>>> work. It could be argued that this shouldn't be supported because it is >>>> a different issue, and the elpa/... directories maintained by >>>> package.el, but in that case I would like some other way to have >>>> package.el manage non-versioned local source. >>> >>> I'm sorry, I don't understand what you're saying here. Who&how does >>> "just clone a project into elpa/devel" and what do you mean by "elpa/devel"? >> >> What I meant was that all directories in ~/.emacs.d/elpa/devel could be >> automatically detected and loaded. > > That's already the case if `~/.emacs.d/elpa/devel` is in > `package-directory-list`, so I don't understand how that relates to what > we're discussing. Unless I am mistaken, `package--make-autoloads-and-stuff' is currently only invoked by `package-unpack', that in turn is only called by the `package-install-from-*' functions. Am I missing something, or how would the autoload file be generated if I just place a repository into ~/.emacs.d/elpa/devel? Of course if this complicates things too much, I won't insist on it, as alternative solutions exists. >> One case where this could be useful for anyone using submodules in >> a versioned configuration. > > Again, I don't understand the relationship. Maybe if you could give > a concrete example scenario? Say a repository consists of only an init.el, and a few submoduled git repositories under /elpa/devel/. These wouldn't include the -pkg.el or -autoload.el files, so they should be generated as soon as necessary. >>> BTW, I think we should choose some `package--` prefix for the >>> vars&functions related to this new "install from VCS" functionality. >> If it is possible to extract the relevant functionality form package.el >> to package-.el, then of course, but I can also try to stick to this >> otherwise. Do you think this should also include renaming package-fetch? > > Yes. Depending on how good "--" is, we may want to add shorter > aliases, of course, but I think that using a `package--` prefix > will help clarify the design. Ok. > > Stefan > -- Philip Kaludercic