unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Po Lu <luangruo@yahoo.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: master 18ec3fcce9: Restore pending_signals at a point in the DND event loop
Date: Sun, 17 Apr 2022 11:55:23 +0800	[thread overview]
Message-ID: <87sfqcnz2s.fsf@yahoo.com> (raw)
In-Reply-To: <jwvsfqc1jnh.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 16 Apr 2022 23:21:25 -0400")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> This is pretty ugly.
> Why is it that it "does nothing"?  Any hope we can move this restoration
> of `pending_signals` closer to the code that "does nothing"?

No, because we don't know the prior value of `pending_signals' in that
code.

In general, the interaction between async input and the event loop run
during a drag is pretty confusing, especially on GTK+.  This solves the
last case of SelectionRequest events being mishandled (because the
selection events are being stored in the wrong `hold_quit' buffer)
during a drag-and-drop operation on GTK.



  reply	other threads:[~2022-04-17  3:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <165015596397.5558.5393619769224500857@vcs2.savannah.gnu.org>
     [not found] ` <20220417003924.49D86C01684@vcs2.savannah.gnu.org>
2022-04-17  3:21   ` master 18ec3fcce9: Restore pending_signals at a point in the DND event loop Stefan Monnier
2022-04-17  3:55     ` Po Lu [this message]
2022-04-17  5:21       ` Stefan Monnier
2022-04-17  5:53         ` Po Lu
2022-04-20 15:05           ` Stefan Monnier
2022-04-21  0:29             ` Po Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfqcnz2s.fsf@yahoo.com \
    --to=luangruo@yahoo.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).