From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Semyonov Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] New packages: Vcomplete, swsw Date: Sun, 22 May 2022 18:55:54 +0300 Message-ID: <87sfp15zp1.fsf@dsemy.com> References: <875ylx4yvn.fsf@dsemy.com> <87h75hyehx.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11657"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 22 18:02:52 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nso2e-0002rq-5R for ged-emacs-devel@m.gmane-mx.org; Sun, 22 May 2022 18:02:52 +0200 Original-Received: from localhost ([::1]:44994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nso2c-0007o3-E5 for ged-emacs-devel@m.gmane-mx.org; Sun, 22 May 2022 12:02:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51786) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsnw1-0006mi-2I for emacs-devel@gnu.org; Sun, 22 May 2022 11:56:01 -0400 Original-Received: from dsemy.com ([46.23.89.208]:23924) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nsnvz-0000Hf-7U for emacs-devel@gnu.org; Sun, 22 May 2022 11:56:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=dkim; bh=xL4CNu7BrOKdQ Z42VbWpFny1vKE3SeoNeyTb/3bye/Q=; h=in-reply-to:date:references: subject:cc:to:from; d=dsemy.com; b=tdNXIsbv1Cd0iCtRto8ET28hr7b05AdtCdH s+N7jM4ZdxrQreJ6bMta1AVQJpBBh17oGaw+VhTz9zhfeSOPIIvSYFvpJyeH0ujsk9l5aD 0LmJ7Omxc8hf7dH2udBB9z2Zir6EFm2z/d0Qw52YIfLV1l5GaLSEqy81CiCyBJzLRrpPD2 +DTHzPpzl8+Dl7tdV4puGYdlKT8WLvL042A5MK6FfdpqLPxuYvIhHva2RZCzZzXDxdy5BW tY754jM0sBED+iJzCLM4Dv8zE3XRCR2258Wut9NmsMadGZt9wsYx0XCRUhieqvzImGACXR HXW2xFsgH1pIckicXrjlxEz8RQg== Original-Received: from coldharbour (bzq-79-183-62-6.red.bezeqint.net [79.183.62.6]) by dsemy.com (OpenSMTPD) with ESMTPSA id 7bddaaad (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 22 May 2022 17:55:56 +0200 (CEST) Original-Received: from localhost (coldharbour [local]) by coldharbour (OpenSMTPD) with ESMTPA id 976373fa; Sun, 22 May 2022 15:55:54 +0000 (UTC) In-Reply-To: <87h75hyehx.fsf@posteo.net> (Philip Kaludercic's message of "Sun, 22 May 2022 11:48:42 +0000") Received-SPF: pass client-ip=46.23.89.208; envelope-from=daniel@dsemy.com; helo=dsemy.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290097 Archived-At: >>>>> Philip Kaludercic writes: > - You add vcomplete-embark.el, that seems to be a package in it's > own right (with a dependency on embark), but with your patch this > will just be bundled into the same package. Is this intentional? Semi-intentional... now that you mention it, is it possible for two (related) packages to share the same git repository? If so, vcomplete-embark should be its own package. In any case, I haven't tested this integration in a while, so I think it would make more sense to completely exclude 'vcomplete-embark.el' for now (this integration broke in the past due to changes to Embark and Vcomplete, and might be broken in some way now as I don't currently use Embark). I'll do some testing in the next few days. > - A practice I have taken up for my own packages on SourceHut is > to add the mailing list as the maintainer. I'm not saying you > should do the same, just that it might make sense to mention it > somewhere. That's actually a very nice idea, thanks. > - The -pkg.el file should be unnecessary, as ELPA generates its > own. Since both packages are complex (as in, they contain multiple files), when I generate my own package tar (for distribution on my site for example, as the packages weren't available on any archive before), it needs to contain a -pkg.el file for Emacs to install it (or at least that's what I remember from testing I did long ago). I will admit this file should just be generated automatically during the build process in this case too, I just never got around to implementing that. > - Could the vector key syntax ([?\C-a]) be replaced with a (kbd > "C-a")? I think the general trend nowadays is towards the latter, > and more people are familiar with it. Now that you mention it, since it's just an example, wouldn't it make more sense to use 'keymap-set' for it? (Although technically both packages could be used with an Emacs version that doesn't support 'keymap-set'). > - You should probably format the reference to the manual in your > commentary section as described in the Info node (elisp) > Documentation Tips. Fixed, thanks. > Have you made up your mind about the name, or could you be > convinced to change it to something like "window-switch" or > "windswitch" (so that it sounds similar to windmove)? Just > suggestions of course, I just anticipate a discussion on this > question, because the name itself is not that expressive. I wouldn't mind changing the name (I agree it's not very good), however I would have to change this name in quite a few places. OTOH, with 'list-packages' showing a brief description of each package, I'm not sure if I see a big benefit to changing the name. I'll have to think about it. >> Both packages include Texinfo manuals (from which the manuals on >> their homepages is generated). Please let me know beforehand if >> there is intention to add either package to NonGNU ELPA, so I >> could update their manuals and add '.elpaignore' files to their >> repositories. > I don't see why not. Those changes have now been made for both packages. >> PS: I initially intended to submit these packages to GNU ELPA, >> but unfortunately I probably won't be able to assign copyright >> any time soon. (I'm assuming it would be possible to move them to >> GNU ELPA in the future?) > It should be possible. Great! BTW, when the packages are first imported, would the latest commit be used, or should I bump the version (after I make all relevant changes)?