From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: master e5d76634a2: Make remapped keys work in set-transient-map Date: Tue, 24 May 2022 14:56:00 +0200 Message-ID: <87sfozhyxr.fsf@gnus.org> References: <165330421099.23674.7590022790639219967@vcs2.savannah.gnu.org> <20220523111011.525EAC051FF@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2072"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 24 15:13:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntULV-0000J1-Fz for ged-emacs-devel@m.gmane-mx.org; Tue, 24 May 2022 15:13:09 +0200 Original-Received: from localhost ([::1]:40342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ntULT-0001gU-Tv for ged-emacs-devel@m.gmane-mx.org; Tue, 24 May 2022 09:13:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntU56-0003jg-8T for emacs-devel@gnu.org; Tue, 24 May 2022 08:56:12 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:53104) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntU54-0007gV-Js for emacs-devel@gnu.org; Tue, 24 May 2022 08:56:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QLELm7daiD+QGOZQo1NPy1nlBCwLOc/bWbkkG/UdJ08=; b=vYdXkGq/EbvdXITc0FvcZh5OOt cTCA6SzbjNq9hTN81ozSJXpsXujRI8ddjVWUocuzOhCZOy7V00lgA5hyIAWpAmUPShn1Ca3IFYTca q7pvyfw3Y6LG3hETcGHQXR01QtINH9uQmAyLjXWfUvowiw35RkL83BX2834poLblVof0=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ntU4u-0006uw-IB; Tue, 24 May 2022 14:56:03 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEXx2XDz3XOvmmWK d1Lh07NXSTT////pI14vAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+YFGAw2O2CJIwoAAAGeSURBVDjL zZTRccMgDIbBE+BOwAn5PQfhPSFMEKr9V+kvY2M77QBVzndBH/plJBljjLFzN7f/UTMf9gvMs52N Vb+Z7V8RusfaA3xRxI/0ce4MzOSNIfJ+ZLpm3GxE1A/754C41lL7A3vuwMqLCxipN3N97EW0aaEQ qQQqFISLH9UNROFNlBKFJERvt0csMaGyAEASQ3QjOWpeCxBCoXYb1Q0txFJiitoSgBExISJFyu+U 4iLJ7xE2lBa51OW7QizF5wCJkLwwNRyxUH3qQG0lKXq4lNemK7CbVNWDVxFi3fHQZveI0O4rYELZ +AQQAHUAiN4htQOuEEtBRCvMCszRj8iQKnhpqhguaztY3pBiJNd51BxmAz2tSGqpdSnTX1cE69By yyLxACZIwpryoqDxKfkSM8QABHJRk28AG3PkDqT5EfHCMt9JMjDG4QaX6wAeHC5XWcfnLJWbMO+D 9bzkELQJ9mKt7pgSWQ1+ft3PkxjWwQnVPWjy/gAf36Ab3zkKZmny17thv0omQx4yE/kBxs1iL4Jn fXcB3l3Ww34AihKWY6BlVA4AAAAldEVYdGRhdGU6Y3JlYXRlADIwMjItMDUtMjRUMTI6NTQ6NTgr MDA6MDDiq+aOAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIyLTA1LTI0VDEyOjU0OjU4KzAwOjAwk/Ze MgAAAABJRU5ErkJggg== X-Now-Playing: Cris Williamson's _The Changer and the Changed_: "Song Of The Soul" In-Reply-To: (Stefan Monnier's message of "Mon, 23 May 2022 08:41:25 -0400") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290185 Archived-At: Stefan Monnier writes: > The remapping could also come from [remap ] bindings in some other > active keymap so maybe we should skip passing `map` to > `command-remapping`. Yes, I guess. Now fixed. > Then again, maybe we don't really need to check (eq this-command mc) > at all, and just make sure `lookup-key` found a binding in `map`. I was unable to convince myself one way or another here, so I left this logic as is, but feel free to adjust if you think that won't regress anything. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no