* Re: master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now
[not found] ` <20220603110939.F1B93C06564@vcs2.savannah.gnu.org>
@ 2022-06-03 12:19 ` Stefan Kangas
2022-06-04 11:26 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Kangas @ 2022-06-03 12:19 UTC (permalink / raw)
To: Emacs developers, Lars Ingebrigtsen
Lars Ingebrigtsen <larsi@gnus.org> writes:
> branch: master
> commit 977f3f27c549db27a2d6fb33e0112b03f9b57371
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
> Don't issue warnings for Unicode quotes for now
>
> * lisp/emacs-lisp/bytecomp.el (byte-compile-docstring-style-warn):
> Remove warning for "Unicode quotes" for now (bug#55780).
How about keeping the warning but making it optional instead? That
way, we could still use it in emacs.git.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now
2022-06-03 12:19 ` master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now Stefan Kangas
@ 2022-06-04 11:26 ` Lars Ingebrigtsen
2022-06-04 21:04 ` Stefan Kangas
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-04 11:26 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Emacs developers
Stefan Kangas <stefan@marxist.se> writes:
> How about keeping the warning but making it optional instead? That
> way, we could still use it in emacs.git.
Hm... With a separate build target or something? For a warning like
this to be useful, it has to actually trigger for most people when
building Emacs.
Or I guess the Makefile could just switch the warning on?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now
2022-06-04 11:26 ` Lars Ingebrigtsen
@ 2022-06-04 21:04 ` Stefan Kangas
2022-06-06 12:22 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Kangas @ 2022-06-04 21:04 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Emacs developers
Lars Ingebrigtsen <larsi@gnus.org> writes:
> > How about keeping the warning but making it optional instead? That
> > way, we could still use it in emacs.git.
>
> Hm... With a separate build target or something? For a warning like
> this to be useful, it has to actually trigger for most people when
> building Emacs.
>
> Or I guess the Makefile could just switch the warning on?
I was thinking of making it depend on a separate variable or user
option that we would set as a directory local variable. Could such an
approach work?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now
2022-06-04 21:04 ` Stefan Kangas
@ 2022-06-06 12:22 ` Lars Ingebrigtsen
2022-06-18 14:39 ` Stefan Kangas
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-06 12:22 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Emacs developers
Stefan Kangas <stefan@marxist.se> writes:
> I was thinking of making it depend on a separate variable or user
> option that we would set as a directory local variable. Could such an
> approach work?
Yes. But it feels a bit awkward to introduce a variable just for this.
We do have byte-compile-warnings, which can be either t or a list, and
it would be nice if we could extend that to cover this use case, to
avoid introducing another mechanism. But we want t to mean
"everything-but-this"... Hm...
Perhaps we could make an explicit mapping: t to `(not
(docstrings-unicode-quotes ...))' and then introduce a new `emacs-build'
value that's the old t (basically)? That way we could (in the future)
introduce more warnings just for the Emacs build that wouldn't affect
other usages of the byte compiler.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now
2022-06-06 12:22 ` Lars Ingebrigtsen
@ 2022-06-18 14:39 ` Stefan Kangas
2022-06-19 11:37 ` Lars Ingebrigtsen
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Kangas @ 2022-06-18 14:39 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Emacs developers
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Yes. But it feels a bit awkward to introduce a variable just for this.
That's true.
> Perhaps we could make an explicit mapping: t to `(not
> (docstrings-unicode-quotes ...))' and then introduce a new `emacs-build'
> value that's the old t (basically)? That way we could (in the future)
> introduce more warnings just for the Emacs build that wouldn't affect
> other usages of the byte compiler.
I like this approach. It would allow us to introduce experimental
byte-compiler warnings: we could introduce new warnings more gently.
For example, perhaps the "long docstrings" warning could have started
out as experimental for a full major release to allow packages more
time to adapt. (Not that it would have likely mattered much but
still.)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now
2022-06-18 14:39 ` Stefan Kangas
@ 2022-06-19 11:37 ` Lars Ingebrigtsen
0 siblings, 0 replies; 6+ messages in thread
From: Lars Ingebrigtsen @ 2022-06-19 11:37 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Emacs developers
Stefan Kangas <stefan@marxist.se> writes:
> I like this approach. It would allow us to introduce experimental
> byte-compiler warnings: we could introduce new warnings more gently.
> For example, perhaps the "long docstrings" warning could have started
> out as experimental for a full major release to allow packages more
> time to adapt.
Yup. So I've now implemented this in Emacs 29 (and reinstated the
Unicode quote check during the Emacs build).
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-19 11:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <165425457951.24295.4901777157797017566@vcs2.savannah.gnu.org>
[not found] ` <20220603110939.F1B93C06564@vcs2.savannah.gnu.org>
2022-06-03 12:19 ` master 977f3f27c5 2/2: Don't issue warnings for Unicode quotes for now Stefan Kangas
2022-06-04 11:26 ` Lars Ingebrigtsen
2022-06-04 21:04 ` Stefan Kangas
2022-06-06 12:22 ` Lars Ingebrigtsen
2022-06-18 14:39 ` Stefan Kangas
2022-06-19 11:37 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).