From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [NonGNU ELPA] 11 new packages! Date: Sat, 26 Nov 2022 20:17:09 +0000 Message-ID: <87sfi5h3ne.fsf@posteo.net> References: <87r0y6ug9z.fsf@disroot.org> <87y1sct2hp.fsf@posteo.net> <87k03vf5m8.fsf@disroot.org> <87edu2narn.fsf@posteo.net> <8735aieqtr.fsf@disroot.org> <87cz9mlq3o.fsf@posteo.net> <875yfdd5ad.fsf@disroot.org> <87wn7hh438.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5423"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Developer List To: Akib Azmain Turja Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Nov 26 21:17:34 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oz1cD-0001A5-7B for ged-emacs-devel@m.gmane-mx.org; Sat, 26 Nov 2022 21:17:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oz1bz-00065X-1i; Sat, 26 Nov 2022 15:17:19 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz1bv-000629-Cj for emacs-devel@gnu.org; Sat, 26 Nov 2022 15:17:15 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oz1br-00045L-FD for emacs-devel@gnu.org; Sat, 26 Nov 2022 15:17:14 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A0FAD240101 for ; Sat, 26 Nov 2022 21:17:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669493828; bh=vwham8xOrVqRhpQq7KEJs1sRgjSOztSt91AnIoZju24=; h=From:To:Cc:Subject:Date:From; b=Mx+PPH6R5RlYh/spz15kF5N0RuaUEXX4kV11p/ZknKf+yvV+NOyz3/87/4Nos91L6 quoOXGHnN4aoe7MOjhPbuqmznAUz8FjxPncylHOIBnfgwyBSp5gtRybqsQyCv52qov s6wQ3rKKqW8DMbb0mJN7zgordEPbWYqJp7e2e8TH4iQl08sVLWNrcOxYMg0YSWBh/p ObuywszfleZoYD7QwytE2XnV+R+PJM3/8geCNXNjZpUScpewoJrjiZoym9apE06NiD y6aVOIyxzPZ8hC0y/VRXxEjm0HsapMb77cjL2o7R5IKZPNPuucYeE7TDgp12c9qyxZ +koVIBjOxm9yQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NKNLX03ZKz6tmg; Sat, 26 Nov 2022 21:17:07 +0100 (CET) In-Reply-To: <87wn7hh438.fsf@posteo.net> (Philip Kaludercic's message of "Sat, 26 Nov 2022 21:07:39 +0100") Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300590 Archived-At: Philip Kaludercic writes: > Akib Azmain Turja writes: > >> Philip Kaludercic writes: >> >>>>> OK, then adding them to NonGNU ELPA seems like the safer bet. >>>>> >>>>> I'd like to add them, but I'll have to take the time to review them >>>>> first, which might take a bit. >>>> >>>> What do you want to review? The patches, or the packages? >>> >>> The packages, unless you aren't interested in comments. >> >> Review if you wish, I welcome feedback. > > One minor one more: > > > > The rest looks fine, so I'll push the commits to nongnu.git. I just realised that none of the patches can be applies, because the last commit in nongnu.git changed the package names from strings to symbols. This makes applying the patches a nuisance. Could you perhaps update the patches to use symbol for names, and make sure nothing has changed?