From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Newsgroups: gmane.emacs.devel Subject: Re: Subprojects in project.el Date: Tue, 29 Nov 2022 10:03:09 +0000 Message-ID: <87sfi2qdr6.fsf@gmail.com> References: <87zgcq68zp.fsf@ericabrahamsen.net> <2ba04533-097a-a1da-ff3f-2c9506fd488e@yandex.ru> <875yf9bbzb.fsf@gmail.com> <87wn7oa0aw.fsf@gmail.com> <7a5b76fd-fb15-8c1e-ea29-bf11f7e0d2ae@yandex.ru> <87bkoya815.fsf@gmail.com> <0024a67d-b8e5-b35c-1b22-82541a170eb3@yandex.ru> <871qptai4d.fsf_-_@gmail.com> <33292672-2a59-ba63-05ab-a7995118a822@yandex.ru> <87pmdau6wo.fsf@gmail.com> <87zgcesg8l.fsf@gmail.com> <79a17a5c-d1c1-ce69-d29a-9127150fb1d7@yandex.ru> <87edtqrr0b.fsf@gmail.com> <0323877a-2198-c295-61c1-5fcb1813f409@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12297"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , Danny Freeman , Eric Abrahamsen , emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Nov 29 11:03:01 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ozxS9-00034m-IK for ged-emacs-devel@m.gmane-mx.org; Tue, 29 Nov 2022 11:03:01 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ozxR8-0005gL-V1; Tue, 29 Nov 2022 05:01:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ozxR6-0005g0-DV for emacs-devel@gnu.org; Tue, 29 Nov 2022 05:01:56 -0500 Original-Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ozxR4-0000Xu-MM for emacs-devel@gnu.org; Tue, 29 Nov 2022 05:01:56 -0500 Original-Received: by mail-wr1-x42d.google.com with SMTP id q7so20314147wrr.8 for ; Tue, 29 Nov 2022 02:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d2yck1PgO7HXSo7tNfwwvkTV5Sa4/qS7HCTaVXinfKA=; b=eC9xoLjDkM7Kq5pf9g4oSuwABhT6oemfsNq4BEOzGAx2mCXQ1cX5Vw1LUBwwLyXZMX 5DsE8hmaYDRzxHV7KMHobxk2RkOZni7rbKhHlxaQtQDw4VbQZBzJTjWEq12/KnnJcIAi /r05yzLt9h7Au2fgbKt4+QK3FiKUXepbvAtdxuXs8VsyOfGMvzj6hB6Fcy1Ua9c1kLSx 7lnn+OOLNEPbqu9iBo+T32WIa2J5YnZcwIsGjJ+LWyDKAeVHSSsNGyowNEmYv1HXgq3i dUE7O9y5g7TvptgM81CWNEAH+zM0ZY0w9TZtH6UWk4hQ9NU8Sic/m3Fa51OmW7Fc57nJ Rf8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d2yck1PgO7HXSo7tNfwwvkTV5Sa4/qS7HCTaVXinfKA=; b=1gFsQU8JabSg9h+Q9y1eBmyUPA0mL7tRzYpCr4gyXN9IBqmpaUGjhIirdf6wNFLmqH 0MopK9uICEZmFSy+NX5E4u4DsZy6bgpLgiQ6aLs9AnPuaNYjXbLjJaWb84Oq5lHePC11 dOo5tDQExY9UFxKcLh/WDsjkal/Oi4clsqvEz3HaGwVhRyl0Avt1zk54UBWN7qcp4Mg6 Z+i1T67Qfipb23XwydK/x53ZLZgG8HyEDeu1YuRwh7yXXd0p8Wr3rokZj+S4mj9NlNU4 kIIqVtKlTjkaQWKtobjYYRkCJ0uha5Wx5AGbQe/JpYTxTD3klTmyiMe8KYtNXyeDvTBK YBaA== X-Gm-Message-State: ANoB5pl5OqcWDSisOlfnleGJrYjBm6d9oHZEQ+VMEpSGawCnqrQDido+ NL/qP8OyoJnkQehBUK7ARtrVURakJXI= X-Google-Smtp-Source: AA0mqf6VpnqsVLtPQp2j2rxEOJGgvRZ82/XwwL307dbDX28rky47/xQNUUhYaAPLQ2SeNocufDyIzQ== X-Received: by 2002:adf:eb8a:0:b0:22e:31b2:ecb9 with SMTP id t10-20020adfeb8a000000b0022e31b2ecb9mr34858295wrn.693.1669716112863; Tue, 29 Nov 2022 02:01:52 -0800 (PST) Original-Received: from krug (87-196-72-71.net.novis.pt. [87.196.72.71]) by smtp.gmail.com with ESMTPSA id n3-20020a1ca403000000b003d005aab31asm1349989wme.40.2022.11.29.02.01.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Nov 2022 02:01:52 -0800 (PST) In-Reply-To: <0323877a-2198-c295-61c1-5fcb1813f409@yandex.ru> (Dmitry Gutov's message of "Sat, 26 Nov 2022 14:38:22 +0200") Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=joaotavora@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300707 Archived-At: Dmitry Gutov writes: > On 26/11/22 11:42, Jo=C3=A3o T=C3=A1vora wrote: >> Dmitry Gutov writes: >>=20 >>> On 26/11/22 02:37, Jo=C3=A3o T=C3=A1vora wrote: >>>> Dmitry Gutov writes: >>>> >>>>>>>> I can't understand what is discourteous about this. >>>>>>> That would be not following the procedure the maintainer has asked = you >>>>>>> to follow. >>>>>> If that means silencing me on emacs-devel, then you're out of luck. >>>>> >>>>> Is that what you do when you ask somebody to use the bug tracker? >>>> I'll use the bug tracker when I think it's appropriate. Let's not >>>> insinuate I'm some kind of inconsiderate delinquent for not moving the >>>> discussion there as you would want. I'm not reporting a bug and I've >>>> politely declined your suggestion, so stop beating this horse. >>> >>> Must be nice to be the person who gets to decide what is appropriate >>> in any situation. >> As long as this list's maintainer doesn't object, I get to decide >> where >> _I_ post to, thank you very much. > > I'll keep that in mind. > >>> By modifying each and every command. I don't think it would be >>> appropriate for 'project-current' itself to react to the value of >>> current-prefix-arg. >> It's very unfortunate to modify "each and every command" unless of >> course you mean doing it via a uniform interface. >> I don't understand why these "project" commands that operate on a >> project don't befittingly take a PROJECT argument. That argument's >> value could be interactively calculated from a >> project-read-project-maybe command that decides if and how to prompt. > > Hysterical raisins. > > But 'C-x p f' and 'C-x p g' call 'project-current' directly. What's > that about some new command? Don't know what you are talking aboutIt seems very reasonable to do this instead: diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index c7b2c386ccd..02f5d25e054 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1151,11 +1151,11 @@ project-compilation-buffer-name-function (function :tag "Custom function"))) =20 ;;;###autoload -(defun project-compile () +(defun project-compile (project) "Run `compile' in the project root." (declare (interactive-only compile)) - (interactive) - (let ((default-directory (project-root (project-current t))) + (interactive (project-current t)) + (let ((default-directory (project-root project)) (compilation-buffer-name-function (or project-compilation-buffer-name-function compilation-buffer-name-function)))