From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?=C3=93scar_Fuentes?= Newsgroups: gmane.emacs.devel Subject: Re: Help sought from C++ expert: is this `value' a type or something else (what)? Date: Thu, 19 Jan 2023 17:22:41 +0100 Message-ID: <87sfg68pf2.fsf@telefonica.net> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17379"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:5qRJUi1xwWdWP3LOCrvsuiuX9KU= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 20 07:35:22 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIkzg-0004Jw-UN for ged-emacs-devel@m.gmane-mx.org; Fri, 20 Jan 2023 07:35:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIkyu-000068-OP; Fri, 20 Jan 2023 01:34:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIXgk-0001TV-Qi for emacs-devel@gnu.org; Thu, 19 Jan 2023 11:22:54 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIXgi-000451-MY for emacs-devel@gnu.org; Thu, 19 Jan 2023 11:22:54 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1pIXgf-0005Vb-2a for emacs-devel@gnu.org; Thu, 19 Jan 2023 17:22:49 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Fri, 20 Jan 2023 01:34:30 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:302563 Archived-At: Alan Mackenzie writes: > Hello, Emacs. > > In the following test file, templates-9.cc from the CC Mode test suite, > on the indicated line, what is the syntactic significance of `value'? > Traditionally, it has fontified with the default face, but recently after > some (not yet committed) changes in CC Mode, it has started getting > font-lock-type-face. > > I don't understand the file at all, hardly, and can't work out whether > the old (non-) fontification was correct, or whether the new > fontification of f-l-type-face is correct. Help would be appreciated. > > Just as a matter of interest, in c++-ts-mode a treesit-query-error gets > thrown. It isn't clear to me whether the file is still valid C++. It is not valid C++ because it misses quite a few declarations. The parser has no way of knowing what `value' is unless it can see the relevant declarations. And even then, in the general case, it is not possible to really know unless your "parser" is, actually, a C++ front end. So both c++-mode and c++-ts-mode are out of their breadth here. IMAO, a reasonable heuristic is to consider it a value unless it is preceded by `typename'.