From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: RE: [External] : Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Thu, 01 Jun 2023 08:10:15 +0000 Message-ID: <87sfbbbo2g.fsf@localhost> References: <875y8nks9t.fsf@localhost> <86pm6sb5g8.fsf@mail.linkov.net> <87ttvsn77s.fsf@localhost> <83edmwfz6p.fsf@gnu.org> <87r0qwk6bz.fsf@localhost> <83ttvseg3k.fsf@gnu.org> <87o7m0k1li.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18750"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , "juri@linkov.net" , "emacs-devel@gnu.org" To: Drew Adams Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 01 10:06:45 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4dKW-0004h1-Te for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Jun 2023 10:06:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4dJi-00009Y-T2; Thu, 01 Jun 2023 04:05:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4dJh-00005b-Da for emacs-devel@gnu.org; Thu, 01 Jun 2023 04:05:53 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4dJe-0006PZ-3u for emacs-devel@gnu.org; Thu, 01 Jun 2023 04:05:53 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 3ADD1240028 for ; Thu, 1 Jun 2023 10:05:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685606746; bh=J/pEx62uas1fvl+AAaigM3ierDPYA/r0VvhVDuPcrl4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=D5SzcKGv6P3EeSkSsR7LEOT8Q2jCMAy5xqq3SK1N3Q1nrFy+RUYhsiqNeQu4yEEi2 Xy2Sz1fSOXxDYDm8vmfjBzMXOWVGN6R9rW/vCaqDZGsYY6UoGx3YxVGJEfQbdjrVF1 +QTG8+y8X9NSBfE6bWDp44Mu0KZrS2rtY56btDKcRmzbND6K0t7tPCi9CwC4+WCoRP aTOtFTqFLMNZq63hHlygv+z3DuxNEo8PB0W7ZkmK14qAuDhodrY8FoUL7t5K7PYjIu YL1rftBbCU/8BJX51DdbXfblO1iv00E/v7O3sKwJrYUieMrN777HTh3SF+EPWbwy2f D7YYbQO8S87+w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QWzGK41X9z6twF; Thu, 1 Jun 2023 10:05:45 +0200 (CEST) In-Reply-To: Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306494 Archived-At: Drew Adams writes: >> Sure. I have no issue with this. That's why I asked to add a word of >> warning about the state of affairs to the docstring. It is not normal >> that major mode-specific predicates are used elsewhere. > > Where do you find that "not normal" guideline? That's my intuition. Is some major or minor mode is defining some customizable predicate function, it is probably going to be called by that mode with mode-specific settings available to that function. > In any case, `isearch-filter-predicate' is not a > "major mode-specific" predicate. `isearch-mode' > is a minor mode. Sure. But I still find calling the predicate outside isearch unexpected. > And note that the first line of its doc string > says that it's for "Isearch and replace commands." > ^^^^^^^^^^^ When reading this docstring, I though that "replace" is referring to `isearch-query-replace'. > Wrt whether `isearch-done' should restore the > original/previous value of `isearch-filter-predicate': I think there is some misunderstanding. I did not intend to mention restoring the original/previous values. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at