From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Thu, 01 Jun 2023 11:44:16 +0000 Message-ID: <87sfbb9zlb.fsf@localhost> References: <875y8nks9t.fsf@localhost> <86pm6sb5g8.fsf@mail.linkov.net> <87ttvsn77s.fsf@localhost> <86o7lzaes4.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9387"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 01 13:40:30 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4gfO-0002EB-8s for ged-emacs-devel@m.gmane-mx.org; Thu, 01 Jun 2023 13:40:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4gfA-0005MA-Du; Thu, 01 Jun 2023 07:40:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4gf2-0005IZ-LN for emacs-devel@gnu.org; Thu, 01 Jun 2023 07:40:08 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4get-000600-P5 for emacs-devel@gnu.org; Thu, 01 Jun 2023 07:40:05 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 2EA02240101 for ; Thu, 1 Jun 2023 13:39:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685619587; bh=HTx23Zj+OwhEbUcLdVtCkFv2M/Knhh6b6GovKGqNyhc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=pJivhGgYgEUR1YYmVjAnb/wZKebU4VC9Ty6sGpyKg//6VDanZoH/02pTJPW3L0Omw s/0s7L/p8zk8ydvXZkgIBsqB8eh4oo7wRsUwYO3AJUhWmufpKgSUiXRmAt43fUUNlL CKRN9IT3sPkPH1FV6/DAHWSp5xLiU3pNGRwz4/fdvrf2OEVTEm7SjZrSF6UF3saWLi kkd5Ey7bBAi2UbePkA7X88uXQFCW5OIFMuuHWbhFWh7j4HonvUwYBYPTdk4h4ewQly A7ik6eGPgVZQSllaGDMcWVOwQKEMik7DZ8RZgBuf/kTjOc0KXpOBHpq0OxfvfML/DA l8xZef84jvZiw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QX41G4XGsz6txM; Thu, 1 Jun 2023 13:39:46 +0200 (CEST) In-Reply-To: <86o7lzaes4.fsf@mail.linkov.net> Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306508 Archived-At: Juri Linkov writes: >> Org produces its own side effects to make isearch >> support revealing text hidden via text properties. > > When your isearch-filter-predicate can't be improved to be > usable also during query-replace, then probably you need to > set isearch-filter-predicate in isearch-mode-hook, and remove > afterwards in isearch-mode-end-hook. Good point. Although I want things to work in query-replace as well. >> It would be nice if the docstring of `isearch-filter-predicate' >> mentioned that it might be called outside isearch-mode. > > isearch.el is both a core library and UI with the search commands. > UI commands for isearch-mode are enabled by C-s, etc. > But as a core library its functions including isearch-filter-predicate > are used by other packages such as replace.el. Which is not documented. I am asking this fact to be documented. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at