From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: Is it valid to call isearch-filter-predicate outside isearch? Date: Fri, 02 Jun 2023 01:22:01 +0200 Message-ID: <87sfbasr8m.fsf@web.de> References: <875y8nks9t.fsf@localhost> <87fs7c10cq.fsf@web.de> <87v8g79zoe.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10516"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: emacs-devel@gnu.org Cancel-Lock: sha1:VoMq/0JfIRcqO4tKivmW0eUHIRI= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 02 01:23:08 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4rdL-0002Tl-Ct for ged-emacs-devel@m.gmane-mx.org; Fri, 02 Jun 2023 01:23:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4rcV-0002lq-Vt; Thu, 01 Jun 2023 19:22:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4rcU-0002lc-Pg for emacs-devel@gnu.org; Thu, 01 Jun 2023 19:22:14 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4rcQ-0000yd-Dd for emacs-devel@gnu.org; Thu, 01 Jun 2023 19:22:14 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1q4rcO-0001Cn-C9 for emacs-devel@gnu.org; Fri, 02 Jun 2023 01:22:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=ged-emacs-devel@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306533 Archived-At: Ihor Radchenko writes: > > If it does, maybe using `post-command-hook' would be a better choice > > than `isearch-end-hook' (which is, obviously, not a good choice)? > > Surely not. `post-command-hook' is triggered after each > `self-insert-command' during isearch/query-replace. Of course the idea is not to so something blindly. One could check whether isearch is still active and which overlays need to be kept. > I had to advice `isearch-clean-overlays', which appears to be called by > all the users of `isearch-filter-predicate' (replace-regexp, evil-mode, > and swipet). Still a workaround. Ugly. Hmm. Maybe the optimum. BTW, did you consider to :before advice the local variable `isearch-filter-predicate' instead of overwriting it? That would be a bit nicer for users and other modes that also need to change it. Michael.